1930115 - For Marionette tests minidump files will be lost when with a restart the Firefox profile is replaced

Status: NEW

(Testing :: Marionette Client and Harness, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I noticed that problem when checking the results for the following Marionette test which is causing a shutdown hang and finally should crash. But that's not happening because the minidump file as already saved to the previous profile in use is removed:

https://treeherder.mozilla.org/logviewer?job_id=481743282&repo=try&lineNumber=1034-1045

[task 2024-11-08T07:44:01.053Z] 07:44:01     INFO -  1731051841053	Marionette	DEBUG	Marionette stopped listening
[task 2024-11-08T07:44:01.054Z] 07:44:01     INFO -  1731051841053	Marionette	DEBUG	1 <- [1,27,null,{"cause":"shutdown","forced":false,"in_app":true}]
[task 2024-11-08T07:44:01.058Z] 07:44:01     INFO -  1731051841057	Marionette	DEBUG	Closed connection 1
[task 2024-11-08T07:45:04.298Z] 07:45:04     INFO -  RunWatchdog: Mainthread nested event loops during hang:
[task 2024-11-08T07:45:04.298Z] 07:45:04     INFO -   --- nsThreadManager::Shutdown|nsThreadPool::ShutdownWithTimeout
[task 2024-11-08T07:45:04.299Z] 07:45:04     INFO -  ExceptionHandler::GenerateDump attempting to generate:</tmp/tmp87_sdmqf.mozrunner/minidumps/75468f21-f88d-e559-2967-457cbf69843b.dmp
[task 2024-11-08T07:45:04.303Z] 07:45:04     INFO -  ExceptionHandler::GenerateDump cloned child 3431
[task 2024-11-08T07:45:04.304Z] 07:45:04     INFO -  ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2024-11-08T07:45:04.304Z] 07:45:04     INFO -  ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2024-11-08T07:45:04.363Z] 07:45:04     INFO -  ExceptionHandler::GenerateDump minidump generation <succeeded
[task 2024-11-08T07:45:04.379Z] 07:45:04     INFO -  <
[task 2024-11-08T07:45:04.409Z] 07:45:04     INFO - Application command: /task_173105129687141/build/application/firefox/firefox -marionette -profile /tmp/tmpqmvl4t58.mozrunner

Because Marionette uses mozcrash to analyze the crash report we could make use of the MINIDUMP_SAVE_PATH environment variable to save crashes happening during the execution of tests are stored in a specific folder. This would also allow us to actually upload the minidump files as artifacts so that they are accessible via Treeherder.

This is similar to geckodriver's bug 1882338. Given that this bug is easier to fix we could get started here and use the outcome for geckodriver later on.