1882338 - Save minidump files if MINIDUMP_SAVE_PATH is set to preserve crash dumps

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is a follow-up from bug 1433495, which actually did not fix the issue.

There is a MINIDUMP_SAVE_PATH environment variable, which can be used with mozcrash to store the created minidump files by the crash reporter into a given folder instead of the Firefox profile. When I was testing the feature I was using wdspec tests, and wptrunner internally uses mozcrash. :/ So it was not visible that just setting the environment variable does nothing.

We could use the same environment variable and / or also add a command line argument to geckodriver to set this path, and if present move the minidump files accordingly.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Gabriele Svelto [:gsvelto] from bug 1585036 comment #30)

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #28)

Gabriele, would it be possible to instruct the crash reporter (maybe via such an environment variable) to not use the default minidump folder? I'm happy to file a bug if wanted and possible.

If you can access JS we already have the minidumpPath property which can be used to set the path where minidumps are written. See how we do it for xpcshell tests.

There is even a way to directly set the path where minidump files can be stored. That makes it even much easier to grab those files.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I'll file a separate bug for Marionette, which we have to get fixed first.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Please note that bug 1884695 won't be fixed in the near future. As such we should implement the minidump handling similar to mozcrash, by checking the minidump folder of the Firefox profile for existing files and copying all of them to the given folder.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Actually for the 0.35.0 release we already have bug 1875773 landed which added the --enable-crash-reporter argument to automatically submit the crash report. This is most likely enough for the upcoming release and we can try to offer a better experience in the 0.36.0 release.

Comment 5

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1882338 - [geckodriver] Save minidump files if MINIDUMP_SAVE_PATH is set to preserve crash dumps.

Comment 6

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1882338 - [mozcrash] Copy minidumps files instead of moving to avoid failures in case files already exist.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7fcc37be80e
[geckodriver] Save minidump files if MINIDUMP_SAVE_PATH is set to preserve crash dumps. r=webdriver-reviewers,jgraham,whimboo
https://hg.mozilla.org/integration/autoland/rev/0d66f48f5e43
[mozcrash] Copy minidumps files instead of moving to avoid failures in case files already exist. r=webdriver-reviewers,whimboo,jmaher

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/49679 for changes under testing/web-platform/tests

Comment 9

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/f7fcc37be80e
https://hg.mozilla.org/mozilla-central/rev/0d66f48f5e43

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot