1930122 - Set network.http.http2.send_NO_RFC7540_PRI to false

Status: VERIFIED FIXED

(Core :: Networking: HTTP, task, P1)

Description

[Valentin Gosu [:valentin]]

There seem to be some servers that close the TLS connection when they encounter this.
Setting to false matches Chrome.

Comment 1

[Valentin Gosu [:valentin]]

Attachment: Bug 1930122 - Set network.http.http2.send_NO_RFC7540_PRI to false r=#necko

Comment 2

[Valentin Gosu [:valentin]]

Attachment: Bug 1930122 - Set network.http.http2.send_NO_RFC7540_PRI to false r=#necko

Original Revision: https://phabricator.services.mozilla.com/D228433

Comment 3

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Some webservers might close the connection
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See bug 1928600
• Risk associated with taking this patch: low
• Explanation of risk level: This patch just makes it so we don't send the SETTINGS_NO_RFC7540_PRIORITIES option. We will then match Chrome. The only risk is that servers might mistakenly use HTTP/2 stream weights for prioritization, instead of the priority header, but the webcompat risk is low considering Chrome is doing the same thing.
• String changes made/needed: none
• Is Android affected?: yes

Comment 4

[Valentin Gosu [:valentin]]

Attachment: Bug 1930122 - Set network.http.http2.send_NO_RFC7540_PRI to false r=#necko

Original Revision: https://phabricator.services.mozilla.com/D228433

Comment 5

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Some webservers might close the connection prematurely leading to a failure to load the page.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See bug 1928600
• Risk associated with taking this patch: low
• Explanation of risk level: This patch just makes it so we don't send the SETTINGS_NO_RFC7540_PRIORITIES option. We will then match Chrome. The only risk is that servers might mistakenly use HTTP/2 stream weights for prioritization, instead of the priority header, but the webcompat risk is low considering Chrome is doing the same thing.
• String changes made/needed: none
• Is Android affected?: yes

Comment 6

[Valentin Gosu [:valentin]]

Attachment: Bug 1930122 - Set network.http.http2.send_NO_RFC7540_PRI to false r=#necko

Original Revision: https://phabricator.services.mozilla.com/D228433

Comment 7

[Phabricator Automation]

esr128 Uplift Approval Request

• User impact if declined: Some webservers might close the connection prematurely leading to a failure to load the page.
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: See bug 1928600
• Risk associated with taking this patch: low
• Explanation of risk level: This patch just makes it so we don't send the SETTINGS_NO_RFC7540_PRIORITIES option. We will then match Chrome. The only risk is that servers might mistakenly use HTTP/2 stream weights for prioritization, instead of the priority header, but the webcompat risk is low considering Chrome is doing the same thing.
• String changes made/needed: none
• Is Android affected?: yes

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80c3d05c3f49
Set network.http.http2.send_NO_RFC7540_PRI to false r=necko-reviewers,kershaw

Comment 9

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/80c3d05c3f49

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/01c8f643657a

Comment 11

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 31 Aug- 11 Sep, please ni? :mboldan]]

Reproduced the issue on Windows 10x64 with Firefox 133.0b6 by opening https://spacedock.info/. A Secure connection failed error is displayed and the network.http.http2.send_NO_RFC7540_PRI pref is set to true.
The issue is verified fixed with Firefox 134.0a1 (2024-11-11) and 133.0b7 from comment 10 on Windows 10x64, macOS 12 and Ubuntu 24. The https://spacedock.info/ is successfully loaded and network.http.http2.send_NO_RFC7540_PRI is set to false.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr128/rev/ee41bed4901e

Comment 13

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 31 Aug- 11 Sep, please ni? :mboldan]]

The issue is verified fixed with Firefox 128.5.0esr on Windows 10x64, macOS 12 and Ubuntu 24. The https://spacedock.info/ is successfully loaded and network.http.http2.send_NO_RFC7540_PRI is set to false.