Add pref to enable Extensible Prioritization Scheme without sending SETTINGS_NO_RFC7540_PRIORITIES
Categories
(Core :: Networking: HTTP, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox132 | --- | fixed |
People
(Reporter: valentin, Assigned: valentin)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [necko-triaged])
Attachments
(2 files)
In Bug 1909666 we re-enabled network.http.http2.enabled.deps due to instances of site breaking.
The sites were breaking because we were sending the SETTINGS_NO_RFC7540_PRIORITIES option.
We should add a separate pref whether to send that, so we can set network.http.http2.enabled.deps to false and not send the option.
It's unclear whether servers will respond to the stream weight dependencies or the Priority header when that happens, but it does make us move forward with this.
Assignee | ||
Comment 1•1 month ago
|
||
Assignee | ||
Comment 2•1 month ago
|
||
Comment 4•23 days ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e824a4a58de7
https://hg.mozilla.org/mozilla-central/rev/2f6a4acf69b2
Updated•21 days ago
|
Comment 5•21 days ago
|
||
My understanding is that
- in FF128 we enabled "Implement Extensible Prioritization Scheme for HTTP/2". There were some issues reported in bug linked from https://bugzilla.mozilla.org/show_bug.cgi?id=1865040#c11, but this remained enabled.
- FF132 this has been disabled again in this issue by switching
network.http.http2.enabled.deps
pref tofalse
.
- Is that right?
- Is the new pref
network.http.http2.send_NO_RFC7540_PRI
notable, given it is default on? - Is there an intent to re-enable this soon?
Assignee | ||
Comment 6•16 days ago
|
||
(In reply to Hamish Willee from comment #5)
My understanding is that
- in FF128 we enabled "Implement Extensible Prioritization Scheme for HTTP/2". There were some issues reported in bug linked from https://bugzilla.mozilla.org/show_bug.cgi?id=1865040#c11, but this remained enabled.
- FF132 this has been disabled again in this issue by switching
network.http.http2.enabled.deps
pref tofalse
.
- Is that right?
- Is the new pref
network.http.http2.send_NO_RFC7540_PRI
notable, given it is default on?- Is there an intent to re-enable this soon?
- Bug 1865040 shipped in 128, but due to regressions we flipped network.http.http2.enabled.deps back to true in bug 1909666 (which got uplifted to 128). We determined that the regressions were most likely caused by the HTTP/2 Push part of the patches, so we disabled HTTP/2 Push in bug 1915848. This bug again disables the pref old HTTP/2 stream dependencies.
- No, it's just a safety pref in case servers misbehave when receiving the new settings parameter.
- We didn't send an intent to ship mostly because this was partly shipped in previous builds - The priority header in bug 1865394 and HTTP/3 priority update frames in bug 1734132
Comment 7•7 days ago
|
||
All of that means (as far as I can tell) no need for any docs changes. Thank you.
Updated•7 days ago
|
Description
•