Open Bug 1930137 Opened 1 year ago Updated 1 month ago

Tab strip, old address bar, and new navigation bar are all visible in tablet split screen mode

Categories

(Firefox for Android :: Toolbar, defect, P3)

All
Android
defect

Tracking

()

UNCONFIRMED

People

(Reporter: csnybot, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:134.0) Gecko/20100101 Firefox/134.0

Steps to reproduce:

Open Firefox
Enter Split Screen

Actual results:

Depending on the size both are displayed

Expected results:

Only one is displayed

The Bugbug bot thinks this bug should belong to the 'Fenix::Toolbar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Toolbar

csnybot, thanks for reporting this problem and sharing the screenshot! It's very helpful for diagnosing the issue.

Your screenshot shows an unexpected combination of the tab strip, the new navigation bar, and the old address bar. We should resolve this issue before we ship the tab strip.

Are the tab strip and navigation bar and address bar all always visible? Or only when you reduce the browser size with split screen mode?

Severity: -- → S3
Priority: -- → P3
Summary: Don't display the Tab Strip and Navigation Toolbar at the same time → Tab strip, old address bar, and new navigation bar are all visible in tablet split screen mode

Thank you for your response

They only become visible in split screen however persists after resizing back to fullscreen

With the browser the size it is in the screenshot it should be like on a phone

Hey [:cpeterson] Tab Strip is working as intended here. The nav bar logic should perform the same screen size (not window size) check that tab strip is using to not display nav bar on large screens regardless of the window size.

This is a feature we will now support in the upcoming toolbar redesign. The user can pick to have both tabstrip and navbar.

Status: UNCONFIRMED → RESOLVED
Closed: 3 months ago
Resolution: --- → INVALID

Would you mind elaborating?

Flags: needinfo?(royang)

We've removed the old navigation bar but will be re-implement navigation bar where the user can choose to see it or not. (Also the new implementation will be cleaner and easier to maintain).

One of the requirement is to allow both tabstrip and navigation bar at the same time. But this will depend on user choice. We will soon have a preview in Nightly. Thanks

Flags: needinfo?(royang)

The navigation bar has been fixed

However I still see the the tab strip when I shouldn't

Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---

This was "fixed" by Bug 1804107 and then regressed at some point

See Also: Bug 1855519

See Also: Bug 1991468

Hey csynbot, thank you for staying on top of this. The navigation bar issue is gone as you stated. If you are still concerned about the tab bar, you will have to manually turn that off in settings if you don't want it. It is completely a user choice now and we won't automatic hide it. If there is anything else we can help you with, let us know, otherwise I would turn to close this bug.

Thank you for your response.

I do "want" the tab tar

It is properly displayed with the tablet address bar

It should hide when the address bar is phone size

That isn't what we are doing anymore. If you do a resize window/splitscreen on mobile, it even shows up then. The only way to hide it now is to disable it .

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: