1930137 - Tab strip, old address bar, and new navigation bar are all visible in tablet split screen mode

Status: RESOLVED INVALID

(Firefox for Android :: Toolbar, defect, P3)

Description

[csnybot]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:134.0) Gecko/20100101 Firefox/134.0

Steps to reproduce:

Open Firefox
Enter Split Screen

Actual results:

Depending on the size both are displayed

Expected results:

Only one is displayed

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Toolbar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[csnybot]

Attachment: Screenshot_Firefox Nightly.jpg

Comment 3

[Chris Peterson [:cpeterson]]

csnybot, thanks for reporting this problem and sharing the screenshot! It's very helpful for diagnosing the issue.

Your screenshot shows an unexpected combination of the tab strip, the new navigation bar, and the old address bar. We should resolve this issue before we ship the tab strip.

Are the tab strip and navigation bar and address bar all always visible? Or only when you reduce the browser size with split screen mode?

Comment 4

[csnybot]

Thank you for your response

They only become visible in split screen however persists after resizing back to fullscreen

With the browser the size it is in the screenshot it should be like on a phone

Comment 5

[csnybot]

Attachment: Screenshot_Firefox Nightly.jpg

Comment 6

[Rahul Sainani [:rsainani]]

Hey [:cpeterson] Tab Strip is working as intended here. The nav bar logic should perform the same screen size (not window size) check that tab strip is using to not display nav bar on large screens regardless of the window size.

Comment 7

[Roger Yang [:royang]]

This is a feature we will now support in the upcoming toolbar redesign. The user can pick to have both tabstrip and navbar.

Comment 8

[csnybot]

Would you mind elaborating?

Comment 9

[Roger Yang [:royang]]

We've removed the old navigation bar but will be re-implement navigation bar where the user can choose to see it or not. (Also the new implementation will be cleaner and easier to maintain).

One of the requirement is to allow both tabstrip and navigation bar at the same time. But this will depend on user choice. We will soon have a preview in Nightly. Thanks