1930145 - Some keywords wrongly trigger a Yelp Suggestion with broken city

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: [Yelp] broken city.mp4

[Affected versions]:

• Firefox Nightly 134.0a1 - Build ID: 20241107212807

[Affected Platforms]:

• Windows 10
• macOS 14.4.1
• Linux Mint 20.1

[Prerequisites]:

• Have following prefs set:
  • browser.search.region = US
  • browser.urlbar.yelp.mlEnabled = true
  • browser.urlbar.quicksuggest.mlEnabled = true
  • browser.ml.enable = true

[Steps to reproduce]:

1. Open the browser using the profile from the prerequisites.
2. Type in the addressbar the "cristiano ronaldo" keyword.
3. Observe the results triggered in the "Firefox Suggest" section.

[Expected result]:

• No Yelp suggestion is triggered.

[Actual result]:

• A Yelp suggestion is triggered which is composed by "subject:cristiano ronaldo" in "location:##istiano ronaldo".

[Notes]:

• This issue is reproducible with the following keywords: cristiano ronaldo, fastfood, inte, potatos, visionare.
• Attached is a screen recording of the issue.

Comment 1

[cgopal]

cristiano ronaldo, fastfood, inte, potatos, visionare are all fixed when I tested in 134.0a1 (2024-11-14) today

Comment 2

[James Teow [:jteow]]

Hey Drew, are there any other validations that are going to be done to ensure that other unrelated keywords won't trigger a Yelp suggestion?

Comment 3

[Drew Willcoxon :adw]

Bug 1931963 and bug 1931964 will address this.

Comment 4

[Drew Willcoxon :adw]

None of the queries in comment 0 show ML Yelp suggestions anymore, so I'll close this. I'm testing on a build with all known bugs fixed, including city validation. Some of those fixes aren't in mozilla-central yet but they will be soon.

Comment 5

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Beta 134.0b1 (Build ID: 20241125200000) and latest Nightly 135.0a1 (Build ID: 20241126093610) on Windows 10 x64, macOS 14.4.1 and Linux Mint 20.1.

• The issue is no longer reproducible with the mentioned keywords in the bug.

We will log new issues if we find other broken results/keywords after all the changes land.