1931964 - Use suggest geonames API to validate ML Yelp suggestions

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Once bug 1931963 is done, we'll need to add some code to desktop to call that API and discard ML Yelp suggestions with invalid cities/states.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1931964 - Use the Suggest geonames API to match locations in Yelp suggestions.

This integrates Yelp suggestions with city/region detection in the Rust
component [1]. That includes both Rust Yelp suggestions and ML Yelp suggestions.
The reason for fixing this bug is to improve ML suggestions by reducing false
positives, but there's no reason we can't also do city/region matching for Rust
suggestions too.

There are two benefits to city/region matching: (1) We can ignore queries with
"invalid" cities/regions, (2) we can do prefix matching, so for example if you
type "ramen in ne", we can match that to "ramen in New York, NY". Of course,
"invalid" doesn't always mean truly invalid. It just means we don't have a match
in our city/region database, which does not contain every city in the world.

This doesn't change how we handle queries that don't contain a location. In
those cases we'll still use geolocation.

This also builds on D229720 so that if multiple cities match the query, we'll
choose the one that best matches the user's location.

[1] Documentation here, source here

Depends on D229720

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/044c06c3df22
Use the Suggest geonames API to match locations in Yelp suggestions. r=daisuke

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/044c06c3df22