1930160 - [a11y] [Toolbar Redesign] Incorrect Talkback announcement for the "Open in Firefox" button in custom tab on phone devices

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P2)

Description

[Delia Pop (Android QA)]

Attachment: OpeninFirefox_Talkback.jpg

Steps to reproduce

1. Firefox Nightly is set as default browser.
2. Turn on Talkback.
3. Open an external app (i.e. Gmail, Instagram, Slack) and tap on a link.
4. Tap on the "Open in Firefox" button from the navigation toolbar (have the toolbar redesign enabled).
5. Observe the Talkback announcement.

Expected behavior

Talkback reads: "Open in Firefox Nightly. Button. Double tap to activate.”.

Actual behavior

On specific devices and orientations Talkback only announces "Open in 2131951720. Button. Double tap to activate.".

Device information

• Firefox version: Nightly 134.0a1 from 11/08 (with the new toolbar)
• Android device model & Android OS version: Samsung Galaxy S22 Ultra (Android 14). Not reproducible with Samsung Tab S8 Ultra 5G (Android 14), Samsung GalaxyZ Fold 4 (Android 13).

Additional information

This issue only occurs on Phone devices, in the Portrait orientation.

Phone device: Top toolbar:

• Portrait mode: Talkback reads "Open in 2131951720. Button. Double tap to activate." -> bug
• Landscape mode: Talkback reads “Open in Firefox Nightly. Button. Double tap to activate.”

Phone device: Bottom toolbar:

• Portrait mode: Talkback reads "Open in 2131951720. Button. Double tap to activate.". -> bug
• Landscape mode: Talkback reads “Open in Firefox Nightly. Button. Double tap to activate.”
  Tested with Samsung Galaxy S22 Ultra (Android 14).

Tablet device: only Top toolbar placement available:

• Portrait mode: Talkback reads “Open in Firefox Nightly. Button. Double tap to activate.”
• Landscape mode: Talkback reads “Open in Firefox Nightly. Button. Double tap to activate.”
  Tested with Samsung Tab S8 Ultra 5G (Android 14)

Foldable device: Top toolbar:

• Portrait mode: Talkback reads “Open in Firefox Nightly. Button. Double tap to activate.”
• Landscape mode: Talkback reads “Open in Firefox Nightly. Button. Double tap to activate.”

Foldable device: Bottom toolbar:

• Portrait mode: Talkback reads “Open in Firefox Nightly. Button. Double tap to activate.”
• Landscape mode: Talkback reads “Open in Firefox Nightly. Button. Double tap to activate.”
  Tested with Samsung GalaxyZ Fold 4 (Android 13)

Comment 1

[Channing]

Release blocker.

Comment 2

[Aaditya Dhingra [:adhingra]]

Attachment: Bug 1930160 - Fix talkback announcement for the "Open in Firefox" button.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/564b073943f9
Fix talkback announcement for the "Open in Firefox" button. r=android-reviewers,007

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/564b073943f9