1930492 - TAB key does not navigate to the next toolbar element while in ‘Tabs’ searchmode

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: tab issue.gif

Found in

• Nightly 134.0a1;

Affected versions

• Nightly 134.0a1;

Affected platforms

• Ubuntu 22;
• macOS 14;
• Windows 10;

Preconditions

• Have browser.urlbar.scotchBonnet.enableOverride set to true
• Have browser.urlbar.searchRestrictKeywords.featureGate set to true

Steps to reproduce

1. Launch Firefox.
2. Select ‘Tabs’ from the Dedicated Search Button.
3. Press TAB.

Expected result

• TAB should have focused the next element in the toolbar.

Actual result

• Focus goes back and forth between Tabs icon and urlbar.

Regression range

• last good: 2024-11-05
• first bad: 2024-11-06
• pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d12754638c687fb1faccb217c2a44a5b66806c37&tochange=d40618764e0c7dbd85ebf103edfb5b602f0bede6
• potentially regressed by: bug 1921174

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1921174

Comment 2

[Mark Banner (:standard8)]

The issue appears to be related to the fact that when there's no heuristic result, we seem to get into the "trapped" state. If in the trapped state, you press the escape key, then you can "escape" the trap.

When you first get into the trapped state, the panel is open, but it is collapsed so you can't really tell that it is open.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1930492: Leave to default tab navigation behavior if no results

Comment 4

[Daisuke Akatsuka (:daisuke)]

Thank you very much! I wrote the patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f918befd4231
Leave to default tab navigation behavior if no results r=urlbar-reviewers,jteow

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/f918befd4231