1921174 - Shift + Tab when the urlbar has been focused (with Ctrl+L) should focus dedicated search button

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

In the default searchbar, with a "secondary" search config, I could:

• cmd + L to focus the address bar
• enter my search query
• hit Tab to move focus to my secondary search button
• hit Enter to trigger the search

With scotchbonnet enabled, I was struggling to do something similar, and I only found out after fiddling around

• cmd + L to focus the address bar
• enter my search query
• hit Escape to hide search results
• hit Shift + Tab to move focus to Search engine selector
• hit Enter to display the dropdown
• move to desired search engine
• hit Enter to validate search engine
• hit Enter to trigger search

Comment 1

[Marco Bonardo [:mak]]

There was an intent of adding a direct shortcut to open and focus the button (though very few shortcuts are left).
we could also evalute making shift+tab not require to close the panel, then it would be consistent with the old behavior, it should maybe also auto-open in this case. It looks like some discussion to have with a11y.

There's something strange in the steps for the old shortcut buttons though, as TAB didn't focus shortcut buttons (unless you pressed it MANY times, or pressed UP multiple times, or ALT+DOWN), and Enter had the same behavior as today (not immediate search, unless one was using SHIFT+ENTER).

Comment 2

[Josh Berman]

I think shift tab should move to the dropdown button and not require to close the panel. The button should not auto-open, but pressing space should open it and close the panel while retaining the keyword and after the menu item is selected, the panel should reopen automatically in the new search mode.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1921174: Move focus to Dedicated Search button by Tab key from urlbar

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4df1b9d10c1f
Move focus to Dedicated Search button by Tab key from urlbar r=daleharvey,urlbar-reviewers,adw

Comment 5

[agoloman]

Backed out for causing bc failures @ browser_searchModeSwitcher_basic.js

• Backout link
• Push with failures
• Failure Log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d40618764e0c
Move focus to Dedicated Search button by Tab key from urlbar r=daleharvey,urlbar-reviewers,adw,dao

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d40618764e0c