Closed Bug 193054 Opened 22 years ago Closed 22 years ago

[FIX]Launching helper does not work if action is changed

Categories

(Core Graveyard :: File Handling, defect, P1)

Product:
Core Graveyard
Component:
File Handling
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.3final

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: regression)

Attachments

(1 file)

fix
7.67 KB, patch
pkwarren
: review+
mscott
: superreview+
asa
: approval1.3+
Details | Diff | Splinter Review
This is a regression from the change to not save helper app data if the user cancels (bug 188724). The problem is that we are not updating the MIME info before trying to handle the data. This blocks figuring out what's really going on in bug 192811 right now....
Attached patch fix — — Splinter Review
Comment on attachment 114271 [details] [diff] [review] fix Phil? Scott? Could you review? (biesi, if you have time to do the r= instead, go for it. ;) )
Attachment #114271 - Flags: superreview?(mscott)
Attachment #114271 - Flags: review?(pkw)
Nominating as blocker for 1.3; this is a very noticeable issue if one tries to use the dialog on things with content-disposition:attachment....
Flags: blocking1.3?
Keywords: regression
Priority: -- → P1
Summary: Launching helper does not work if action is changed → [FIX]Launching helper does not work if action is changed
Target Milestone: --- → mozilla1.3final
Comment on attachment 114271 [details] [diff] [review] fix sr=mscott
Attachment #114271 - Flags: superreview?(mscott) → superreview+
Attachment #114271 - Flags: review?(pkw) → review+
Comment on attachment 114271 [details] [diff] [review] fix Requesting approval for 1.3... the problem this is fixing is users selecting and app to open with, clicking ok... and watching nothing happen. Which is never a good idea.
Attachment #114271 - Flags: approval1.3?
Comment on attachment 114271 [details] [diff] [review] fix a=asa (on behalf of drivers) for checkin to 1.3 final.
Attachment #114271 - Flags: approval1.3? → approval1.3+
fixed for 1.3final
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Flags: blocking1.3?
*** Bug 193415 has been marked as a duplicate of this bug. ***
*** Bug 193662 has been marked as a duplicate of this bug. ***
Marking verified in the Mach-0 OS X 2003-03-13-03 trunk and Win32 2003-03-13-04 trunk builds.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: