1930616 - Add optional NavigationManager using parent process ProgressListener

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

We initially implemented the NavigationManager by listener to progresslistener notifications in the content process, via JSWindowActors. However this leads to additional STOP_STATE notification with NS_BINDING_ABORTED when there is a process switch, which we have to manually ignore. This makes it hard to differentiate between the final STOP_STATE for a navigation and an intermediary one. For instance, for a 204 HTTP response, the final state will be STOP_STATE with NS_BINDING_ABORTED as well, but this one should not be ignored.

The goal of this bug is to reimplement the NavigationManager using parent process progress listeners, and allow to toggle between the two implementations using a preference. We initially had issues with the parent process approach, with some edge cases such as data:uri iframe loads not being picked up.

Comment 1

[Julian Descottes [:jdescottes]]

For the record my initial patch for a parent process navigation listener was at https://phabricator.services.mozilla.com/D163993?id=656417

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1930616 - [remote] Prototype parent process NavigationListener

Depends on D245945

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1930616 - [remote] Rename NavigationListener actors to WebProgressListener

The goal is to reduce the confusion between the high level navigation manager/listener which
provide events about the navigation to WebDriver BiDi with some logic specific to BiDi and the underlying
listeners directly monitoring the platform notifications.

In the next patch in the stack we need to introduce an alternate way to listen to those platform
notifications so having more distinct names could be useful.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd4869f3e372
[remote] Rename NavigationListener actors to WebProgressListener r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/c606c4205607
[remote] Prototype parent process NavigationListener r=webdriver-reviewers,Sasha

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/cd4869f3e372
https://hg.mozilla.org/mozilla-central/rev/c606c4205607

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Julian, would you mind filing a bug to enable the parent process navigation manager by default? That way we can add dependencies and know how much work is left to do. Thanks.