1930676 - Replace MainThreadNotificationObserver with PNotification

Status: RESOLVED FIXED

(Core :: DOM: Notifications, task)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Should be an easier step before we completely remove NotificationRef.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1930676 - Part 3: Add skeleton PNotification functions r=asuth

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1930676 - Part 8: Remove MainThreadNotificationObserver r=asuth

This patch opens an actor in the main thread just because mIsClosed is still a main thread controlled member. It will change to a target thread controlled one when one of the child patches implements Send/RecvShow.

Note that this makes showNotification() even slower and causes WPT failure for now, but that's purely a timing issue that will also be fixed by the Send patch.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: WIP: Bug 1930676 - Part 4: Implement RecvShow

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1930676 - Part 5: Implement RecvNotifyClick r=asuth

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: WIP: Bug 1930676 - Migrate from runnables to IPC

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1930676 - Part 1: Remove redundant promise argument from CreateActor r=asuth

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1930676 - Part 2: Always unpersist on alertfinished r=asuth

An error should still trigger unpersist.

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1930676 - Part 4: Implement RecvClose r=asuth

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1930676 - Part 6: Implement Child::ActorDestroy r=asuth

Comment 10

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1930676 - Part 7: Implement NotificationChild::FrozenCallback r=asuth

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cd49ea657b5
Part 1: Remove redundant promise argument from CreateActor r=asuth
https://hg.mozilla.org/integration/autoland/rev/affda5c4bd6e
Part 2: Always unpersist on alertfinished r=asuth
https://hg.mozilla.org/integration/autoland/rev/3bb3905cd739
Part 3: Add skeleton PNotification functions r=asuth
https://hg.mozilla.org/integration/autoland/rev/4d359273a778
Part 4: Implement RecvClose r=asuth
https://hg.mozilla.org/integration/autoland/rev/284f9a865487
Part 5: Implement RecvNotifyClick r=asuth
https://hg.mozilla.org/integration/autoland/rev/6aa0bf3fc85f
Part 6: Implement Child::ActorDestroy r=asuth
https://hg.mozilla.org/integration/autoland/rev/b4281687df45
Part 7: Implement NotificationChild::FrozenCallback r=asuth
https://hg.mozilla.org/integration/autoland/rev/146e61d3a560
Part 8: Remove MainThreadNotificationObserver r=asuth

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3cd49ea657b5
https://hg.mozilla.org/mozilla-central/rev/affda5c4bd6e
https://hg.mozilla.org/mozilla-central/rev/3bb3905cd739
https://hg.mozilla.org/mozilla-central/rev/4d359273a778
https://hg.mozilla.org/mozilla-central/rev/284f9a865487
https://hg.mozilla.org/mozilla-central/rev/6aa0bf3fc85f
https://hg.mozilla.org/mozilla-central/rev/b4281687df45
https://hg.mozilla.org/mozilla-central/rev/146e61d3a560