1931497 - Replace WorkerNotificationObserver with PNotification

Status: RESOLVED FIXED

(Core :: DOM: Notifications, task)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1931497 - Part 1: Close NotificationParent on RecvClose r=asuth

And also mark as dangling when unregistering, so that Close() won't cause double unregistration.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1931497 - Part 2: Implement tab focusing for workers on RecvNotifyClick r=asuth

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1931497 - Part 3: Add WorkerRef to NotificationChild r=asuth

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1931497 - Part 4: Remove WorkerNotificationObserver r=asuth

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1931497 - Part 5: Remove now-redundant Notification members r=asuth

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1931497 - Part 6: Adjust notification lifetime documentation comment r=asuth

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1931497 - Part 7: Remove parent process ping in PContent and PushService r=asuth

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1931497 - Part 8: Remove parent process ping in PContent and nsAlertsService r=asuth

This should now go through PNotification. The whole cookie thing can now go away which will be done in a followup.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63c83f539c9c
Part 1: Close NotificationParent on RecvClose r=asuth
https://hg.mozilla.org/integration/autoland/rev/914675ac5b1f
Part 2: Implement tab focusing for workers on RecvNotifyClick r=asuth
https://hg.mozilla.org/integration/autoland/rev/25282afc180b
Part 4: Remove WorkerNotificationObserver r=asuth
https://hg.mozilla.org/integration/autoland/rev/415ab0b26eec
Part 5: Remove now-redundant Notification members r=asuth
https://hg.mozilla.org/integration/autoland/rev/e4f61eca8ec9
Part 6: Adjust notification lifetime documentation comment r=asuth
https://hg.mozilla.org/integration/autoland/rev/67448cc45d93
Part 7: Remove parent process ping in PContent and PushService r=asuth
https://hg.mozilla.org/integration/autoland/rev/2d4ee0b414ac
Part 8: Remove parent process ping in PContent and nsAlertsService r=asuth

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/63c83f539c9c
https://hg.mozilla.org/mozilla-central/rev/914675ac5b1f
https://hg.mozilla.org/mozilla-central/rev/25282afc180b
https://hg.mozilla.org/mozilla-central/rev/415ab0b26eec
https://hg.mozilla.org/mozilla-central/rev/e4f61eca8ec9
https://hg.mozilla.org/mozilla-central/rev/67448cc45d93
https://hg.mozilla.org/mozilla-central/rev/2d4ee0b414ac