Closed Bug 193069 Opened 22 years ago Closed 21 years ago

Style notifications need to call BeginUpdate()

Categories

(Core :: CSS Parsing and Computation, defect, P1)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.5alpha

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Our current stylesheet notifications do not call BeginUpdate().  This means that
the HTML content sink doesn't flush its contexts properly; instead it has
hardcoded knowledge of what the CSS frame constructor does and just updates the
contexts after the fact.

Of course this means that other observers that are waiting for ContentAppended
notifications get screwed, since some content is never notified for.  See bug
193014 for an example -- there a script in the <head> sets a sheet enabled,
which triggers all this crap and as a result the content list (which is created
in the call that does the enabled-setting) never gets notification of 3 of the
<link> elements on the page...

So we should have the stylesheet stuff call BeginUpdate.  Or better yet,
identify exactly how the nsIDocument observer-related functionality should be
used and clean up the various users....

So can someone tell me how it's supposed to theoretically work?  Or do we not
really know?  ;) If so, I'll make something up, document it, and make all
callers follow it....
Priority: -- → P1
Target Milestone: --- → mozilla1.5alpha
Depends on: 200931
Blocks: 209217
Fixed by patch in bug 200931
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.