1930840 - [win10] Toolbar buttons are not visible when hovered with High Contrast#1 Windows theme and Firefox System theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: contrast.gif

Found in

• 134.0a1 (2024-11-12)

Affected versions

• 134.0a1 (2024-11-12)
• 133.0b7
• 132.0.2

Tested platforms

• Affected platforms: Windows 10
• Unaffected platforms: macOS 12, Ubuntu 24

Precognitions

• Firefox System theme is set
• High Contrast #1 is set in Windows settings

Steps to reproduce

1. Hover over toolbar buttons.

Expected result

• The buttons displayed as expected.

Actual result

• The buttons are not visible.

Regression range

• The first bug causing buttons to be not visible on hover was bug 1917588. This issue was initially fixed by bug 1916589 but was then reverted by bug 1919611. I’ll set bug 1917588 as the initial regressor; please feel free to update it if this seems incorrect.

Additional notes

• Attached a screen recording.
• The same issue happens with High contrast #2. With High Contrast White there is no hover effect on toolbar buttons or app menu options. With High contrast Black there is no hover effect on App menu options and only an outline effect on toolbar buttons.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:dao, since you are the author of the regressor, bug 1917588, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1930840 - Revert to pre-bug 1917588 toolbarbutton colors. r?#theme

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/118a50b1d73d
Revert to pre-bug 1917588 toolbarbutton colors. r=desktop-theme-reviewers,emilio

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/118a50b1d73d

Comment 5

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: contrast_00.gif

Hello! I looked over this today on Windows 10x64 with Firefox 134.0a1 (2024-11-17) and it seems that the toolbar buttons are now visible on hover but the App Menu options are not (see screen recording). Should I file a new issue for the App menu options or reopen this one? Thank you!

Comment 6

[Donal Meehan [:dmeehan]]

Setting Fx133 to fix-optional.
We could consider this in the scheduled Fx133 dot release.
:dao there is already a pending NI on Comment 5. Please review if you should add an uplift request or it should ride the train with Fx134.

Comment 7

[Dão Gottwald [:dao]]

(In reply to Alexandru Trif, Desktop Test Engineering [:atrif] from comment #5)

Created attachment 9438255 [details]
contrast_00.gif

Hello! I looked over this today on Windows 10x64 with Firefox 134.0a1 (2024-11-17) and it seems that the toolbar buttons are now visible on hover but the App Menu options are not (see screen recording). Should I file a new issue for the App menu options or reopen this one? Thank you!

I may have missed this, sorry about that. I'd appreciate if you could file a new bug. Thanks!

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Dão Gottwald [:dao] from comment #7)

(In reply to Alexandru Trif, Desktop Test Engineering [:atrif] from comment #5)

Created attachment 9438255 [details]
contrast_00.gif

Hello! I looked over this today on Windows 10x64 with Firefox 134.0a1 (2024-11-17) and it seems that the toolbar buttons are now visible on hover but the App Menu options are not (see screen recording). Should I file a new issue for the App menu options or reopen this one? Thank you!

I may have missed this, sorry about that. I'd appreciate if you could file a new bug. Thanks!

Thank you! I have filled bug 1932549 for the remaining issue. Marking this as verified with Firefox 134.0a1 (2024-11-20) because the toolbar buttons are now visible on hover with High Contrast themes on Windows 10x64.

Comment 9

[Dão Gottwald [:dao]]

Comment on attachment 9437954 [details]
Bug 1930840 - Revert to pre-bug 1917588 toolbarbutton colors. r?#theme

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: see comment 0 (This only fixes the toolbar button issue shown there. The issue with the app menu is being tracked in bug 1932549.)
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: -
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Pretty straightforward and well scoped CSS fix
• String changes made/needed: -
• Is Android affected?: No

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9437954 [details]
Bug 1930840 - Revert to pre-bug 1917588 toolbarbutton colors. r?#theme

Fx133 is now in RC. Moving beta uplift request to release for inclusion as a ride along

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox133 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9437954 [details]
Bug 1930840 - Revert to pre-bug 1917588 toolbarbutton colors. r?#theme

Approved for 133.0.3

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/43511f2107c2

Comment 14

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 133.0.3 on Windows 10x64. The Toolbar buttons are correctly visible when hovering with all Windows 10 contrast themes.