1931528 - Revert workaround for asyncOpenTime=0 in webdriver-bidi

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P3)

Description

[Julian Descottes [:jdescottes]]

Once Bug 1931514 is fixed, we could remove the workaround from Bug 1930849. However let's give it some time before we clean it up.
If any network event has the issue we should see the following log:

NetworkRequest] Invalid asyncOpenTime=0 for channel [...]

If we have not seen such a log while using BiDi or reviewing logs in general for a while, we can consider removing the workaround.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Julian, I assume we can revert the workaround now, right?

Comment 2

[Julian Descottes [:jdescottes]]

That feels a bit early? The fix only landed 10 days ago, and we don't have any means of catching the issue outside of manually seeing the logs. I know I've not been checking test logs religiously.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

That sounds fair. So lets wait longer and maybe check again at early next year (or after M14 finished).

Comment 4

[Julian Descottes [:jdescottes]]

Let's table this for m15

Comment 5

[Julian Descottes [:jdescottes]]

Let's go ahead and remove this. This is a very simple bug, if anyone wants to use it to setup their environment.
The only thing to do here is to revert the changes made in https://phabricator.services.mozilla.com/D228780

Comment 6

[biyul.dev]

Attachment: Bug 1931528 - Revert the fallback to channelCreationTime when asyncOpenTime===0 in webdriver-bidi. r=jdescottes

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a3e2ae8779e7
https://hg.mozilla.org/integration/autoland/rev/ae3cd5969a90
Revert the fallback to channelCreationTime when asyncOpenTime===0 in webdriver-bidi. r=jdescottes,webdriver-reviewers

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ae3cd5969a90

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks biyul for working on this bug. If you are interested in working on more bugs please let us know.

Comment 10

[biyul.dev]

Hi Henrik, thank you. I'm interested in helping in the little ways I can. I've just been looking at simple ones at Codetribute and Bugzilla to get onboarded and fix dev env issues along the way.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

That sounds good. Something else not so complicated and more about code removal is bug 1976504, which I filed yesterday. It's not only JS but also Python, and related to another test suite that you could get in touch with. I'm happy to mentor if you have interest to work on it. But if you want to concentrate on JS only just let us know. Thanks.

Comment 12

[biyul.dev]

I had a quick look and I think I know how what I'd need to do. Happy to get that assigned to me!

However I may need help with the Python stuff. The dev env issues I mentioned earlier were actually specifically with Python, so this sounds like a great chance to get it fixed. We can discuss this over chat.mozilla.org since it's not related to the ticket. I can reach out over there tomorrow though our timezones don't line up too well. Cheers