1931579 - Compose Previews are broken and unable to render

Status: RESOLVED FIXED

(Firefox for Android :: Design System and Theming, defect, P2)

Description

[Noah Bond [:007]]

A recent change from a navbar patch nuked Compose previews and all of them are unable to render. Calling components (which is what context.settings() does under the hood), breaks previews, so these calls should be avoided whenever possible.

We would need to either:

1. Wrap the settings calls with the inComposePreview check
2. “Revert” the change and remove the isCustomTab check from Theme.getTheme() and instead have a local when check inside of ExternalAppBrowserFragment to directly specify the theme to the FirefoxTheme wrapper call.
   • So we’d have a when to check for the custom tab logic and then just use the default Theme.getTheme otherwise

Personally, I’d advocate for option 2. The firefox theme wrapper should probably not have knowledge about custom tabs logic, especially if it’s only used in one location, but also to keep Theme.getTheme as minimal as possible.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1925679

Comment 2

[[:skhan]]

Reverting bug 1925679's patch
https://phabricator.services.mozilla.com/D229170

Comment 3

[[:harrisono]]

Attachment: Bug 1931579 - Fix Custom Tab private theme for Navigation Bar on orientation change

Comment 4

[[:skhan]]

Fixed with the revert mentioned above