1925679 - [Toolbar Redesign] Custom Tabs Private Browsing mode theme not respected by Navigation toolbar on orientation change

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect, P2)

Description

[tchoh]

Attachment: image.png

Steps to Reproduce:

1. Set Nightly as the default browser.
2. Set the app to open custom tab in private.
3. Configure settings to open new tabs in Nightly.
4. Open a custom tab within the app.

As a note, my System theme is Light and my app theme follows system theme.

Expected Result: The custom tab opens in Nightly with the correct theme, including the navbar matching Nightly's expected color scheme.

Actual Result: The custom tab opens in Nightly, but the navbar appears white, preventing proper visibility of the expected colors.

Comment 1

[[:skhan]]

Verified this is occurring for me on rotating the device once or max twice!
Nightly 133.0a1 of 18th October, 2024.

Comment 2

[[:harrisono]]

This seems to have been fixed sometime in the past couple of days.

Except now there's a problem with the Custom Tabs Navigation Toolbar not respecting the private browsing theme if Fenix is set to open links in private browsing mode.

I've narrowed it down to FirefoxTheme not having the proper color set for layer1 after an ExternalAppBrowserFragment recomposes when orientation changes. I'll investigate further.

Comment 3

[[:harrisono]]

This issue will be fixed by this PR for a separate ticket:
https://phabricator.services.mozilla.com/D223253

Bugzilla ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1910628

Comment 4

[[:skhan]]

Attachment: Bug 1925679 - Fix theme issue of navbar on rotation in custom tab

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4bd4e0e79d6
Fix theme issue of navbar on rotation in custom tab r=android-reviewers,petru,harrisono

Comment 6

[Goloman Adrian[:agoloman]]

https://hg.mozilla.org/mozilla-central/rev/b4bd4e0e79d6

Comment 7

[[:skhan]]

Attachment: Revert "Bug 1925679 - Fix theme issue of navbar on rotation in custom tab"

This reverts commit 92eef53516ab11a86872ae6127d76f678a1e99d2.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/abc9d6c4c2d0
Revert "Bug 1925679 - Fix theme issue of navbar on rotation in custom tab" r=android-reviewers,007,harrisono

Comment 9

[[:harrisono]]

Attachment: Bug 1925679 - Fix Custom Tab private theme for Navigation Bar on orientation change

Comment 10

[amarc]

The revert merged to central: https://hg.mozilla.org/mozilla-central/rev/abc9d6c4c2d0

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebd70faa8d9a
Fix Custom Tab private theme for Navigation Bar on orientation change r=android-reviewers,skhan

Comment 12

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/ebd70faa8d9a