1931712 - Tidy up picker code in file-utils.js in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, enhancement)

Description

[Ian Neal]

At the moment:

• getPicker gets passed an object as an argument but only uses one of the properties of that object
• pickSaveAs has 5 possible arguments but only ever gets called with at most 3 of them
• pickOpen has 4 possible arguments but only ever gets called with at most 2 of them

Tidy up involves:

• setting a null default for futils.lastSaveAsDir and futils.lastOpenDir so the code doesn't have to check for their existence.
• removing MSG_SAVE_AS and MSG_OPEN fallbacks, as a title is always passed through as an argument.
• dropping the object argument from getPicker instead passing the only used property (defaultString) as an argument.
• removing the 2 unused arguments from pickSaveAs and pickOpen.

Comment 1

[Ian Neal]

Attachment: 1931712-irc-file-utils-picker-tidy-25320.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9438156 [details] [diff] [review]
1931712-irc-file-utils-picker-tidy-25320.patch

lgtm r/a+

Comment 3

[Frank-Rainer Grahl (:frg)]

Btw. https://searchfox.org/comm-central/source/suite/chatzilla/js/lib/file-utils.js#187

picker.show no longer works after Bug 1387800. Still fine for 2.53 but something for the future.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/3227aaf70906
Tidy up picker code in file-utils.js in cZ. r=frg