193178 - google sidebar search removes '+' characters.

Status: RESOLVED EXPIRED

(SeaMonkey :: Search, defect)

Description

[Robert Sim]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130

Searching google with the sidebar for "C++" yields hits for "C  ".  I like C,
but I prefer C++. ;-)  Note that searching google directly for "C++" yields the
desired results, and the "C++" term is correctly copied to the sidebar.  

This bug extends to the advanced features of google, since, iirc, prefixing a
keyword with '+' indicates that hits must include that keyword.

Reproducible: Always

Steps to Reproduce:
1. Use the sidebar to search google for C++
Actual Results:  
I got hits for "C  " (note the '+') is replaced with whitespace.

Expected Results:  
It should not have removed the '+'.

Comment 1

[Lapo Luchini]

Actually it doesn't remove '+', just doesn't URL-convert them.. and '+' sign
just happens to be a space in the URL format...
Actually it correctly converts spaces to '%20', though.
Also '&' is correctly encoded.

This is correlated to bug 153027.

Using Mozilla 1.4b+ Build ID 2003052608.

Comment 2

[Ben Hutchings]

Actually, '+' does not normally need to be escaped in a URL. However, for
historical reasons there are special rules in a query part - '+' represents
space and a literal '+' must be escaped as '%2B'.
Mozilla should check whether the '%s' in a search template or CKQ is in a query
part (i.e. has a '?' somewhere before it) and use the alternate escaping rule if so.

Comment 3

[Alex Hirzel]

*** Bug 220200 has been marked as a duplicate of this bug. ***

Comment 4

[Frank Wein [:mcsmurf]]

Reporter: Is this still a problem with a current Mozilla build? This is wfm with
a current Mozilla build.

Comment 5

[Robert Sim]

> Reporter: Is this still a problem with a current Mozilla build? This is wfm with
> a current Mozilla build.

It's no longer a problem in Mozilla 1.6 (on Fedora Core 2).  Also not a problem
in the search box in Firefox 0.9.2.

Comment 6

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 7

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.