1932021 - Hovering over a function in minified source doesn't let you navigate to the destination

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

STR:

<script src=scope.js></script>

scope.js:

var o=f();o.inc();o.m();console.log(o.get());function f(){var p=0;var k=5;return{inc:function(){p++},get:function(){return p},m:function(){console.log("fod")}}}

Load the above and unminify the js source. Set the debugger to break on the first line o=f(). Hover over f and then click on 'go to function' button. It doesn't navigate or highlight f in yellow.

If scope.js isn't minified in the first place it works fine.

Comment 1

[Julian Descottes [:jdescottes]]

Bomsy built a test page for this bug: https://bug-1932021.glitch.me/

Evaluating f in the console and jumping to definition from there actually works, so it should be feasible to fix this in the debugger.
Note that jump to definition in the debugger seems flaky and doesn't always work, might not be only about unminified files.

Comment 2

[Alexandre Poirot [:ochameau] [PTO back August 21]]

Attachment: Bug 1932021 - [devtools] Fix navigating to pretty print sources from debugger previews.

Comment 3

[Alexandre Poirot [:ochameau] [PTO back August 21]]

I'm having some more general fixes around pretty print to land first in bug 1917012.

Comment 4

[Holger Benl [:hbenl]]

I've found another case where the jump-to-definition button doesn't work:

<script>
function f() {}
const x = { f };
debugger;
</script>

if you debug this file and hover over f then the jump-to-definition button works but if you hover over x then the jump-to-definition button for the f property doesn't work.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d94b7377fdfe
[devtools] Fix navigating to pretty print sources from debugger previews. r=devtools-reviewers,bomsy

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/d94b7377fdfe