1947692 - Can't navigate to function location of properties in preview popup

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Holger Benl [:hbenl]]

What were you doing?

Open devtools and navigate to this file:

<script>
function f() {}
const x = { f };
debugger;
</script>

Then hover over x and click the "Jump to definition" button for f.

What happened?

Nothing

What should have happened?

The definition of f should be highlighted.

Comment 1

[Holger Benl [:hbenl]]

The cause seems to be https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/components/Editor/Preview/Popup.js#153-161: the onViewSourceInDebugger function ignores the location that is passed to it and tries to open the location of the root object shown in the preview instead.

Comment 2

[Holger Benl [:hbenl]]

Attachment: Bug 1947692 - [devtools] Fix jump-to-definition button for object properties in preview popups. r=#devtools-reviewers,ochameau

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b81478edf348
[devtools] Fix jump-to-definition button for object properties in preview popups. r=ochameau,devtools-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b81478edf348