1932188 - [Sections Personalization] Context menu

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Scott [:thecount] Downe]

The sections need a context menu with a block section menu item. There is a component for context menus, but we need to add a new item in https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/lib/link-menu-options.mjs

The follow work is also going to add a conditional unfollow button to the context menu, not needed to happen in bug 1932187.

Comment 1

[npypchenko]

Attachment: Bug 1932188 - [Sections Personalization] Context menu r=#home-newtab-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/643f1437f3a5
[Sections Personalization] Context menu r=home-newtab-reviewers,fluent-reviewers,bolsson,thecount

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/643f1437f3a5

Comment 4

[Contact team at [e-mail]]

I've verified this task on the latest Nightly 135.0a1 build (build id: 20241212095112), on macOS Sequoia 15.0.1, on Windows 11 x64 and on Ubuntu 22.04 x64. Putting on enabled the following two prefs: "browser.newtabpage.activity-stream.discoverystream.sections.enabled" and "browser.newtabpage.activity-stream.discoverystream.sections.personalization.enabled”, the Context menu is coming on the page, but I've noticed two things:

1. The context menu opens sideways, while in the Figma it appears to open downwards. What's the intended behaviour?
2. In the Figma, if the status is "Following" for one section, the context menu contains two options: "Unfollow Topic" and "Block". Currently, in the latest Nightly 135.0a1 build, the Context menu has only one option: "Block". (please see the attached screenshot). Is this the desired behaviour?

Comment 5

[Contact team at [e-mail]]

Attachment: contextMenu.png

Comment 6

[Scott [:thecount] Downe]

Yeah this work was just for the context menu itself.

It still have some work.

See bug 1936618 and bug 1932187.

Comment 7

[Contact team at [e-mail]]

Thanks for the answer, Scott.
In this case, I'll verify the whole behaviour when bug 1936618 and bug 1932187 will be closed.