1932553 - Implement telemetry for showing and dismissing the menu CFR in the menu redesign

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Implement telemetry for showing and dismissing the menu CFR in the menu redesign. This is a regression from Bug 1915092

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1932553 - Part 1: Refactor showQuitMenu parameter order in MainMenu

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1932553 - Part 2: Collect telemetry for Save and Tools menu click in the menu redesign

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1932553 - Part 3: Implement telemetry for showing and dismissing the menu CFR in the menu redesign

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1915092

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1915092

Comment 7

[Iorga Gabriel]

Hi, what about these bugs?
The telemetry for the “New: Streamlined menu” CFR message is NOT registered after the message is displayed in Treatment A branch
The "customize homepage" button from the menu should not generate a telemetry event for the homepage button
The “browser_menu_action.tools_submenu” and “browser_menu_action.save_submenu” events are NOT registered after tapping on the “Tools” or “Save” submenu options while enrolled in the Treatment A branch

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90e546ca6024
Part 1: Refactor showQuitMenu parameter order in MainMenu r=sanchaai,android-reviewers
https://hg.mozilla.org/integration/autoland/rev/361c92f61b1e
Part 2: Collect telemetry for Save and Tools menu click in the menu redesign r=sanchaai,android-reviewers

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Iorga Gabriel from comment #7)

Hi, what about these bugs?
The telemetry for the “New: Streamlined menu” CFR message is NOT registered after the message is displayed in Treatment A branch

This is resolved in https://phabricator.services.mozilla.com/D229748 as part of this bug using the CFR telemetry added in Bug 1885640 specifically for showing the menu CFR prior before they were in erroneously https://bugzilla.mozilla.org/show_bug.cgi?id=1915092.

The “browser_menu_action.tools_submenu” and “browser_menu_action.save_submenu” events are NOT registered after tapping on the “Tools” or “Save” submenu options while enrolled in the Treatment A branch

This is resolved with https://phabricator.services.mozilla.com/D229747 as part of this bug..

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/90e546ca6024
https://hg.mozilla.org/mozilla-central/rev/361c92f61b1e

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gl, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox134 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e2c3c8e5c2e
Part 3: Implement telemetry for showing and dismissing the menu CFR in the menu redesign r=android-reviewers,sanchaai

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3e2c3c8e5c2e

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Is this needed on Beta for the experiments targeting Beta 134?

Comment 17

[Gabriel Luong [:gl] (ΦωΦ)]

Forwarding this to Sanchaai to figure out with the team.