1915092 - [Menu Redesign] Menu CFR is incorrectly positioned after rotating screen

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P2)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: MenuCFRAnchoring.mp4

Steps to reproduce

1. Ensure the redesigned menu has not been shown before
2. Open the redesigned menu
3. While the redesigned menu CFR is shown rotate the screen

Expected behavior

The CFR is still shown at the top of the menu and in the horizontal middle

Actual behavior

The CFR is placed in the left bottom half of the menu

Comment 1

[tchoh]

https://www.figma.com/design/RFz9fYtotQCQuinwcZujZt/%5B%5D-Menu-Redesign?node-id=11412-108977&t=qUJn1l57c0a2dlgy-4

Following a discussion with the design team, the requirements have changed for displaying the CFR. The CFR will only be shown the first time the Menu is opened for an existing user. If the device is rotated, the CFR will be dismissed and will not reappear.

Comment 2

[tchoh]

Attachment: Bug 1915092 - Menu CFR orientation position change

Comment 3

[Chris Peterson [:cpeterson]]

We'll want to fix this CFR bug before our beta experiment.

Comment 4

[Mira Lobontiu (Android QA)]

Attachment: az_recorder_20241030_152118 - Trim.mp4

This is the behavior on a tablet.
The arrow is not sticked on the CFR, as it can be seen in the short video.

Tested with Samsung Galaxy Tab S9 Ultra (Android 14), and Lenovo TB X606X (Android 10).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9efa2d7e9e4c
Menu CFR orientation position change r=android-reviewers,skhan

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9efa2d7e9e4c

Comment 7

[Mira Lobontiu (Android QA)]

Attachment: az_recorder_20241120_144808_edited.mp4

This is the behavior on the latest Fenix Nightly 134.0a1 from 11/20 on a Samsung Galaxy Tab S9 Ultra (Android 14) tablet.

Comment 8

[Petru-Mugurel Lingurar [:petru]]

@Tim think that for at least one other CFR we decided with UX to automatically dismiss it when the screen is rotated? Should we try something similar here?