1933003 - Add support to use restricted search keywords in both en-US and the localized language

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Mandy Cheang [:mcheang][she/her] - Away Oct 5– Nov 9]

Attachment: about-preferences-search.png

When the user is in a localized language (e.g. es-ES) they should be able to use both the localized keyword and the English keyword.
For example, if the user is using Spanish locale, the user can use @marcadores and the en-us keyword @bookmarks.

Please see screenshots for a demo of the changes in the address bar results and in about:preferences#search.

PREF:

• set browser.urlbar.searchRestrictKeywords.featureGate to true

Acceptance Criteria for results panel

• Should list the restrict keywords result as @localizedkeyword, @englishKeyword - Search <Localized Search Mode>
• See address-bar-result screenshot for example in Spanish

Acceptance Criteria for about:preferences#search

• Should see the localized search mode under "Search Engine" column
• Should see @localizedKeyword, @englishKeyword, restrict token
• See about-preferences-search screenshot for example in Spanish

Acceptance Criteria for English Autofill

• type out the full English keyword and space @bookmarks , address bar should show results panel with history results
• type @bo and press right arrow, shows results panel with bookmarks results
• type @bo and press enter, shows results panel with bookmarks results
• Type @bo and press tab, shows results panel with bookmarks results

Acceptance Criteria for Spnaish Autofill

• type out the full Spanish keyword and space @marcadores , address bar should show results panel with history results
• type @m and press right arrow, shows results panel with bookmarks results
• type @m and press enter, shows results panel with bookmarks results
• Type @m and press tab, shows results panel with bookmarks results

Comment 1

[Mandy Cheang [:mcheang][she/her] - Away Oct 5– Nov 9]

Attachment: address-bar-result.png

Comment 2

[Mandy Cheang [:mcheang][she/her] - Away Oct 5– Nov 9]

Attachment: Bug 1933003 - Add support to use restricted search keywords in both en-US and the localized language. r=mak

This patch adds English restrict keyword strings to the enUS-searchFeature.ftl
file. The restrictKeywords providers return an array of keywords for their
l10nRestrictKeywords property. The first is the localized keyword, and the
second is the English keyword. If the user is in the English locale, the
providers return an array with one element: the English keyword.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/affc08e4c2e4
Add support to use restricted search keywords in both en-US and the localized language. r=mak,fluent-reviewers,settings-reviewers,urlbar-reviewers,mossop

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/affc08e4c2e4