1933591 - Implement new <select> HTML parser rules

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, enhancement)

Description

[Joey Arhar]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/132.0.0.0 Safari/537.36

Steps to reproduce:

Parse <select><div><option>

Actual results:

<div> is not included in resulting DOM

Expected results:

<div> should be included in resulting DOM

We are updating the HTML parser rules for <select> here: We are changing the HTML parser for <select> here: https://github.com/whatwg/html/pull/10557

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Keith Cirkel [:keithamus]]

Customisable select will significantly alter the parser with respect to select elements; by removing the "in select" and "in select in table" parser mode, but adding parse error modes to many elements (besides <option>, <optgroup>, and <hr>) if they are a descendant of a <select> element.

Comment 4

[Jan Jaeschke [:jjaschke]]

Attachment: WIP: Bug 1933591 - Customizable Select: Remove `IN_SELECT` to relax parsing for select elements. r=hsivonen!,#dom-core,keithamus

Comment 5

[sideshowbarker [:sideshowbarker]]

FYI at https://github.com/validator/htmlparser/pull/113 I have a patch for the Java sources that’s been waiting on review

Comment 6

[Keith Cirkel [:keithamus]]

Attachment: Bug 1933591 - Implement new (pref gated) parser rules for <select> r=hsivonen

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a5d02e457e17
https://hg.mozilla.org/integration/autoland/rev/6579ee887825
Implement new (pref gated) parser rules for <select> r=hsivonen

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4ec02d27d372
https://hg.mozilla.org/integration/autoland/rev/7b5d7d64bb82
Revert "Bug 1933591 - Implement new (pref gated) parser rules for <select> r=hsivonen" for causing wpt failures in select-inside-top-layer.html.

Comment 9

[Serban Stanca [:SerbanS]]

Reverted this because it was causing wpt failures in select-inside-top-layer.html.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | /html/semantics/forms/the-select-element/customizable-select/select-inside-top-layer.html | a modal dialog can be nested inside select - assert_true: the select should be showing expected true got false

Please also check these bp-nu bustages.

• Failure Log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9d54a37f9870
https://hg.mozilla.org/integration/autoland/rev/2131eac71a4a
Implement new (pref gated) parser rules for <select> r=hsivonen

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e61df9cc1fbf
https://hg.mozilla.org/integration/autoland/rev/3d108e4002b3
Revert "Bug 1933591 - Implement new (pref gated) parser rules for <select> r=hsivonen" for causing bp-nu bustages in nsHtml5Parser.cpp.

Comment 12

[Silaghi Andreea]

Backed out for causing bp-nu bustages in nsHtml5Parser.cpp.
Backout Link
Push with failures
Failure Log
Failure line /builds/worker/checkouts/gecko/parser/html/nsHtml5Parser.cpp(691,7): error: use of undeclared identifier 'StaticPrefs'

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/decc227363dd
https://hg.mozilla.org/integration/autoland/rev/a272b8338e67
Implement new (pref gated) parser rules for <select> r=hsivonen

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58595 for changes under testing/web-platform/tests

Comment 15

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a272b8338e67

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot