1974784 - Make <select> look through all descendants for <option> elements

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Keith Cirkel [:keithamus]]

Right now <select> looks through children & <optgroup> children for <option> elements, but should be updated to look through all of its descendants in the DOM tree for <option> elements.

Comment 1

[Jan Jaeschke [:jjaschke]]

Attachment: Bug 1974784 - Customizable Select: Support options inside wrapper elements. r=#dom-core,keithamus,emilio!

Extends the option list, disabled state, and optgroup notification logic to
handle options nested inside wrapper elements (e.g. <div> inside <select>),
per the spec's "list of options" and "concept-option-disabled" algorithms.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f8f965189623
https://hg.mozilla.org/integration/autoland/rev/7e3c0e80b625
Customizable Select: Support options inside wrapper elements. r=emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60314 for changes under testing/web-platform/tests

Comment 4

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/7e3c0e80b625

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/244264d46002
https://hg.mozilla.org/integration/autoland/rev/7789ad17172f
Revert (Bug 1974784, Bug 2038588) for causing wpt failures @ options-length-too-large.html

Comment 7

[amarc]

Backed out for causing wpt failures

• Backout link
• Push with failures
• Failure Log

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60347 for changes under testing/web-platform/tests

Comment 9

[Serban Stanca [:SerbanS]]

Backout merged in central: https://hg-edge.mozilla.org/mozilla-central/rev/7789ad17172f2a6dc0519a3e0a8682ab2736dc8a

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/64079ed7abad
https://hg.mozilla.org/integration/autoland/rev/060cd41ffb90
Customizable Select: Support options inside wrapper elements. r=emilio

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/060cd41ffb90

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60378 for changes under testing/web-platform/tests

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot