1934555 - Close Tabs Below content menu option has artifact in string on Windows 10

Status: RESOLVED INVALID

(Firefox :: Sidebar, defect, P2)

Description

[Sarah Clements [:sclements]]

Strings were updated in bug 1906881 for the "close multiple tabs" tab context menu options to support the vertical tabs orientation. However, it seems a strange artifact is being added to one of the strings on Windows 10 and Ubuntu 22, but not macOS.

For the option in vertical tabs, the "Close Tabs Below (I)", because it has the extra "(I)" part at the end.

Comment 1

[Dave Townsend [:mossop]]

(In reply to Sarah Clements [:sclements] from comment #0)

Strings were updated in bug 1906881 for the "close multiple tabs" tab context menu options to support the vertical tabs orientation. However, it seems a strange artifact is being added to one of the strings on Windows 10 and Ubuntu 22, but not macOS.

For the option in vertical tabs, the "Close Tabs Below (I)", because it has the extra "(I)" part at the end.

This is indicating that the access key for the menu item is "I". Normally we underline the access key in the menu label but in this case the label doesn't include an I character anywhere so it gets appended to the end.

Comment 2

[Sarah Clements [:sclements]]

(In reply to Dave Townsend [:mossop] from comment #1)

(In reply to Sarah Clements [:sclements] from comment #0)

Strings were updated in bug 1906881 for the "close multiple tabs" tab context menu options to support the vertical tabs orientation. However, it seems a strange artifact is being added to one of the strings on Windows 10 and Ubuntu 22, but not macOS.

For the option in vertical tabs, the "Close Tabs Below (I)", because it has the extra "(I)" part at the end.

This is indicating that the access key for the menu item is "I". Normally we underline the access key in the menu label but in this case the label doesn't include an I character anywhere so it gets appended to the end.

Oh, I didn't realize the access key is appended automatically on windows and ubuntu. What seems strange though is this same key it isn't appended when in horizontal tabs mode. In vertical tabs, this is the only access key being appended - neither the "Close Tabs Above" nor "Close Other Tabs" have their access keys appended.

Comment 3

[Dave Townsend [:mossop]]

(In reply to Sarah Clements [:sclements] from comment #2)

(In reply to Dave Townsend [:mossop] from comment #1)

(In reply to Sarah Clements [:sclements] from comment #0)

Strings were updated in bug 1906881 for the "close multiple tabs" tab context menu options to support the vertical tabs orientation. However, it seems a strange artifact is being added to one of the strings on Windows 10 and Ubuntu 22, but not macOS.

For the option in vertical tabs, the "Close Tabs Below (I)", because it has the extra "(I)" part at the end.

This is indicating that the access key for the menu item is "I". Normally we underline the access key in the menu label but in this case the label doesn't include an I character anywhere so it gets appended to the end.

Oh, I didn't realize the access key is appended automatically on windows and ubuntu. What seems strange though is this same key it isn't appended when in horizontal tabs mode. In vertical tabs, this is the only access key being appended - neither the "Close Tabs Above" nor "Close Other Tabs" have their access keys appended.

"Close Tabs to Right", "Close Tabs Above" and "Close Other Tabs" already contain their access keys in the existing label text. It is only automatically appended when the letter isn't already present.

Comment 4

[Sarah Clements [:sclements]]

Sorry, I missed the part where you said that the others are underlined (which is quite subtle in the menu). Do you know why it doesn't apply to macOS though? Is that a known issue?

Comment 5

[Dave Townsend [:mossop]]

I'm not sure whether we ever display these on macOS. Possibly you have to enable some accessibility setting. Markus, do you know?

Comment 6

[Markus Stange [:mstange]]

macOS native menus do not support accesskeys, and there is no setting to enable them.