1906881 - Update strings for Close multiple tabs and New tab in the tab right-click menu (see comment 5)

Status: VERIFIED FIXED

(Firefox :: Sidebar, defect, P1)

Description

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Attachment: close multiple tabs .png

Found in

• Nightly 130.0a1

Affected versions

• Nightly 130.0a1 (2024-07-09)

Affected platforms

• All

Preconditions

• Set the following prefs:
  sidebar.revamp - true
  sidebar.verticalTabs - true

Steps to reproduce

1. Open multiple tabs on the vertical sidebar
2. Right click on a tab and hover over "Close multiple tabs"

Expected result

• The options are for example "Close above tabs" & "Close below tabs"

Actual result

• The options are the ones from the horizontal tabs "Close tabs to left" and "Close tabs to right"

Regression range

• Not a regression

Additional Notes

• See the issue in the attachment

Comment 1

[Sarah Clements [:sclements]]

That's a good catch, thanks!

Comment 3

[Kelly Cochrane [:kcochrane]]

As outlined in this document, if vertical tabs has been enabled, we should use "Close Tabs Above" and "Close Tabs Below" here rather than "Close Tabs to Right" and "Close Tabs to Left".

Comment 5

[Ania]

Let's please use this ticket to update all strings for the horizontal and vertical tabs right-click menu that were changed after the latest content design review:
reference doc:

1. New Tab to Right (please note that horizontal right-click item also needs to be updated from "New Tab") - > New Tab Below (vertical tabs)
2. Close Tabs to Left - > Close Tabs Above (vertical tabs)
3. Close Tabs to Right -> Close Tabs Below (vertical tabs)

Comment 6

[Sarah Clements [:sclements]]

Attachment: Bug 1906881 - Update tab context menu strings for vertical tabs mode r=#tabbrowser-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35d99092ebb4
Update tab context menu strings for vertical tabs mode r=fluent-reviewers,mconley,bolsson

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/35d99092ebb4

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sclements, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox131 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Daniel Bodea [:danibodea]]

Release v131.0 (before the fix):

1. horizontal tabs mode: the specific labels for the relevant context menu options:
   "New Tab", "Close Tabs to Left", "Close Tabs to Right" and "Close Other Tabs"
2. vertical tabs mode: the specific labels for the relevant context menu options:
   "New Tab", "Close Tabs to Left", "Close Tabs to Right" and "Close Other Tabs"

Release v132.0.2 and RC v133.0 (after the fix):

1. horizontal tabs mode: the specific labels for the relevant context menu options:
   "New Tab to Right", "Close Tabs to Left", "Close Tabs to Right" and "Close Other Tabs
2. vertical tabs mode: the specific labels for the relevant context menu options:
   "New Tab Below", "Close Tabs Above", "Close Tabs Below (I)" and "Close Other Tabs"

As it can be observed, the new tags are correct, except the "Close Tabs Below (I)", because it has the extra "(I)" part at the end.
The behavior detailed above is observed in WIndows 10 and Ubuntu 22. On MacOS 11, the changes seem flowless as the Close Tabs Below label does not contain the "(I)" part.

Sarah, can you look into the remaining issue here?

Comment 12

[Sarah Clements [:sclements]]

Thanks for flagging, I've filed bug 1934555 to capture this.