1934878 - Data URIs should have a valid Size column in netmonitor

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P2)

Description

[Julian Descottes [:jdescottes]]

Since we reused the BiDi implementation for the data URIs support in DevTools, we currently have no size defined because this was postponed to followup Bug 1903807.

The issue is that it is not clear from a spec point of view if BiDi should set non-0 sizes here.

However for DevTools it probably makes sense to at least display a valid size in the corresponding column.
To do that we can fill the size property of the response, without touching bodySize and decodedBodySize. WebDriver BiDi is not reading size so it should be ok.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1934878 - [devtools] Set a valid size for data URIs requests in netmonitor

Set the response.text.length as response.size in NetworkObserver events for data URIs.
Fields used by WebDriver BiDi are not updated here. The existing data-uri test is updated in
order to check the size column.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24fff4275b89
[devtools] Set a valid size for data URIs requests in netmonitor r=devtools-reviewers,ochameau

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/24fff4275b89