Closed Bug 1935360 Opened 2 months ago Closed 2 months ago

[Toolbar Redesign][Menu Redesign] navigation_bar.browser_menu_tapped and navigation_bar.home_menu_tapped events are not generated when the new menu is enabled

Categories

(Fenix :: Experimentation and Telemetry, defect)

Firefox 135
All
Android
defect

Tracking

(firefox133 disabled, firefox134 verified, firefox135 verified)

VERIFIED FIXED
135 Branch
Tracking Status
firefox133 --- disabled
firefox134 --- verified
firefox135 --- verified

People

(Reporter: dpop, Assigned: skhan)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Steps to reproduce

  1. Have the new toolbar and new menu enabled.
  2. Use Glean Debug Tools to trigger telemetry events.
  3. Open the app, and go to homepage > Tap the "Menu" (3-dot menu) button from the Navigation Toolbar. > Navigate to Glean Debug Viewer and observe the displayed pings.
  4. Navigate to any webpage > Tap the "Menu" (3-dot menu) button from the Navigation Toolbar. > Navigate to Glean Debug Viewer and observe the displayed pings.

Expected behavior

The following events should be displayed:

67      "timestamp": 30,
68      "category": "events",
69      "name": "toolbar_menu_visible",
70      "extra": {
71        "glean_timestamp": "1733391111711"
72      }
73    },
74    {
75      "timestamp": 1258,
76      "category": "navigation_bar",
77      "name": "home_menu_tapped",
78      "extra": {
79        "glean_timestamp": "1733391112940"
80      }
 {
151      "timestamp": 7727,
152      "category": "navigation_bar",
153      "name": "browser_menu_tapped",
154      "extra": {
155        "glean_timestamp": "1733391119408"
156      }

Actual behavior

The navigation_bar.browser_menu_tapped and navigation_bar.home_menu_tapped events are not generated when the new menu is enabled.

Device information

  • Firefox version: Nightly 135.0a1 from 12/05 (with the new toolbar and menu enabled)
  • Android device model & Android OS version: Samsung GalaxyZ Fold 4 (Android 13)

Additional information

The events are correctly generated when only the new toolbar is enabled.
Menu tapped (while in home screen): https://dictionary.telemetry.mozilla.org/apps/fenix/metrics/navigation_bar_home_menu_tapped
Menu tapped (while site opened): https://dictionary.telemetry.mozilla.org/apps/fenix/metrics/navigation_bar_browser_menu_tapped

Blocks: 1935417
No longer blocks: 1935417
Assignee: nobody → skhan
Status: NEW → ASSIGNED
Pushed by sarahkhan1107@hotmail.com: https://hg.mozilla.org/integration/autoland/rev/c6eb91382451 Add navigation bar telemetry for new menu r=android-reviewers,tchoh
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch

Comment on attachment 9442014 [details]
Bug 1935360 - Add navigation bar telemetry for new menu

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: Need telemetry for toolbar redesign experiment.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Enable navigation bar
  1. Enable menu redesign
  2. Tap on the new menu on navigation bar
  3. Test if telemetry is fired.
  • List of other uplifts needed: Bug 1935696
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's just telemetry
  • String changes made/needed: No
  • Is Android affected?: No
Attachment #9442014 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Please also request uplift in Bug 1935696 once it has landed in mozilla-central, thanks.

Flags: needinfo?(skhan)

Verified as fixed in Nightly 135.0a1 from 12/10 with Google Pixel 8 Pro (Android 14).
The navigation_bar.browser_menu_tapped and navigation_bar.home_menu_tapped events are now correctly generated when the new menu is enabled.

{
159      "timestamp": 83750,
160      "category": "navigation_bar",
161      "name": "home_menu_tapped",
162      "extra": {
163        "glean_timestamp": "1733837316047"
164      }
165    },
166    {
167      "timestamp": 83755,
168      "category": "events",
169      "name": "toolbar_menu_visible",
170      "extra": {
171        "glean_timestamp": "1733837316053"
172      }

{
129      "timestamp": 4599,
130      "category": "navigation_bar",
131      "name": "browser_menu_tapped",
132      "extra": {
133        "glean_timestamp": "1733837340563"
134      }
135    },
136    {
137      "timestamp": 4601,
138      "category": "events",
139      "name": "toolbar_menu_visible",
140      "extra": {
141        "glean_timestamp": "1733837340566"
142      }
143    },

Ping
I'll leave the "qe-verify+" flag until this can also be verified in Beta.

(In reply to Pascal Chevrel:pascalc from comment #5)

Please also request uplift in Bug 1935696 once it has landed in mozilla-central, thanks.

Added. Thanks!

Flags: needinfo?(skhan)
Attachment #9442014 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
See Also: → 1936537

Verified as fixed in Beta 134.0b9 (Build #2016061290), hg-615791f9752c+, GV: 134.0-20241211100452, AS: 134.0 on Samsung Galaxy A53 5G (Android 14).
Marking this as verified.

{
80      "timestamp": 1344,
81      "category": "navigation_bar",
82      "name": "browser_menu_tapped",
83      "extra": {
84        "glean_timestamp": "1733998655270"
85      }
86    },

{
137      "timestamp": 4449,
138      "category": "navigation_bar",
139      "name": "home_menu_tapped",
140      "extra": {
141        "glean_timestamp": "1733998658375"
142      }
143    },

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: