Weather widget location search placeholder text is not localized
Categories
(Firefox :: New Tab Page, defect, P1)
Tracking
()
People
(Reporter: maxx, Assigned: maxx)
References
(Blocks 1 open bug)
Details
Attachments
(4 files, 1 obsolete file)
4.23 KB,
image/png
|
Details | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
48 bytes,
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-release+
|
Details | Review |
STR:
- Change the following prefs:
browser.newtabpage.activity-stream.discoverystream.region-weather-config
:US,CA,PL
browser.newtabpage.activity-stream.discoverystream.locale-weather-config
:US,CA,PL
- Change region to "pl"
- Change browser locale to "pl"
- Open new tab
- Click "…" button on Weather widget and click first item in context menu "Change location" (Should be translated to Polish)
- Expected: Search location input should become visible and placeholder should be the string "Search location" (Translated to Polish)
- Actual: Search location input is only in English
Assignee | ||
Comment 1•2 months ago
|
||
Assignee | ||
Comment 2•2 months ago
|
||
Untranslated string: https://searchfox.org/mozilla-central/rev/8c9c85c74e366c11ffacbb5a2e457b33b0acc9cd/browser/components/newtab/content-src/components/Weather/LocationSearch.jsx#104
Confirmed the string to be used is already translated: https://transvision.mozfr.org/?sourcelocale=en-US&locale=pl&repo=gecko_strings&search_type=entities&recherche=browser/browser/newtab/newtab.ftl:newtab-weather-change-location-search-input&entire_string=entire_string
Assignee | ||
Comment 3•2 months ago
|
||
Assignee | ||
Comment 5•2 months ago
|
||
Updated•2 months ago
|
Assignee | ||
Comment 8•2 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D231311
Updated•2 months ago
|
Comment 9•2 months ago
|
||
beta Uplift Approval Request
- User impact if declined: This would impact the timeline for the weather widget to be rolled out to users
- Code covered by automated testing: yes
- Fix verified in Nightly: yes
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: See testing steps in this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1935504#c0 (Note: Requires you to change geo/region and locales
- Risk associated with taking this patch: Low
- Explanation of risk level: This string has been translated for over 6 months - just not in use. This feature is being rolled out to non-English locales for the first time
- String changes made/needed: A Fluent migration is included in the patch and was verified by @bolsson
- Is Android affected?: no
Assignee | ||
Comment 10•2 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D231311
Updated•2 months ago
|
Comment 11•2 months ago
|
||
release Uplift Approval Request
- User impact if declined: This would impact the timeline for the weather widget to be rolled out to users
- Code covered by automated testing: yes
- Fix verified in Nightly: yes
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: See testing steps in this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1935504#c0 (Note: Requires you to change geo/region and locales
- Risk associated with taking this patch: Low
- Explanation of risk level: This string has been translated for over 6 months - just not in use. This feature is being rolled out to non-English locales for the first time
- String changes made/needed: A Fluent migration is included in the patch and was verified by @bolsson
- Is Android affected?: no
Updated•2 months ago
|
Comment 12•2 months ago
|
||
uplift |
Updated•2 months ago
|
Updated•2 months ago
|
Comment 13•2 months ago
•
|
||
Comment on attachment 9442239 [details]
Bug 1935504 - Update weather widget location search input placeholder string to be translated r?#home-newtab-reviewers
Approved for 133.0.3
- also taking the lint fix in Bug 1935756
Comment 14•2 months ago
|
||
uplift |
Updated•2 months ago
|
Comment 15•2 months ago
|
||
I have verified this issue on the latest Firefox dot release 133.0.3 (Build ID: 20241209150345), Firefox Beta 134.0b8 (Build ID: 20241209091406), and the latest Nightly 135.0a1 (Build ID: 20241209213901) on Windows 10 x64, macOS 14.4.1 and Linux Mint 20.1. Here are the results:
On Firefox Beta 134.0b8 and latest Nightly 135.0a1:
- The issue is no longer reproducible, the string is correctly localized.
On Firefox Dot Release 133.0.3:
- The issue is still reproducible, the string is NOT localized.
@Maxx, could you please take a look if the patch is successfully merged in Firefox 133.0.3? Or the string is not localized on Firefox 133 because there are some feature differences and the patch is not working as expected compared to Beta and Nightly?
Comment 16•2 months ago
|
||
@Donal, the patch doesn't seem to work on the Firefox 133.0.3 release. I am pinging you also for visibility.
Comment 17•2 months ago
|
||
Thanks for the heads up, :maxx will need to investigate.
:maxx this might mean you cannot rollout the experiment on Fx133.
We don't have any more dot releases planned for Fx133.
If your investigation finds anything additional is needed in release, then you will need to wait until Fx134 hits release.
Assignee | ||
Comment 18•2 months ago
|
||
@Donal - Got'cha. Understood. Investigating now.
Description
•