Closed Bug 1935504 Opened 2 months ago Closed 2 months ago

Weather widget location search placeholder text is not localized

Categories

(Firefox :: New Tab Page, defect, P1)

defect

Tracking

()

RESOLVED FIXED
135 Branch
Tracking Status
firefox133 --- fixed
firefox134 --- verified
firefox135 --- verified

People

(Reporter: maxx, Assigned: maxx)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

STR:

  1. Change the following prefs:
  • browser.newtabpage.activity-stream.discoverystream.region-weather-config : US,CA,PL
  • browser.newtabpage.activity-stream.discoverystream.locale-weather-config : US,CA,PL
  1. Change region to "pl"
  2. Change browser locale to "pl"
  3. Open new tab
  4. Click "…" button on Weather widget and click first item in context menu "Change location" (Should be translated to Polish)
  5. Expected: Search location input should become visible and placeholder should be the string "Search location" (Translated to Polish)
  6. Actual: Search location input is only in English
Attached image Untranslated state

ST

Severity: -- → S2
Priority: -- → P1
Pushed by mcrawford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f235fae4c103 Update weather widget location search input placeholder string to be translated r=home-newtab-reviewers,fluent-reviewers,nbarrett,bolsson
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
Attachment #9442041 - Attachment is obsolete: true
Depends on: 1935756
Attachment #9442235 - Flags: approval-mozilla-beta?

beta Uplift Approval Request

  • User impact if declined: This would impact the timeline for the weather widget to be rolled out to users
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: See testing steps in this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1935504#c0 (Note: Requires you to change geo/region and locales
  • Risk associated with taking this patch: Low
  • Explanation of risk level: This string has been translated for over 6 months - just not in use. This feature is being rolled out to non-English locales for the first time
  • String changes made/needed: A Fluent migration is included in the patch and was verified by @bolsson
  • Is Android affected?: no
Flags: qe-verify+
Attachment #9442239 - Flags: approval-mozilla-release?

release Uplift Approval Request

  • User impact if declined: This would impact the timeline for the weather widget to be rolled out to users
  • Code covered by automated testing: yes
  • Fix verified in Nightly: yes
  • Needs manual QE test: yes
  • Steps to reproduce for manual QE testing: See testing steps in this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1935504#c0 (Note: Requires you to change geo/region and locales
  • Risk associated with taking this patch: Low
  • Explanation of risk level: This string has been translated for over 6 months - just not in use. This feature is being rolled out to non-English locales for the first time
  • String changes made/needed: A Fluent migration is included in the patch and was verified by @bolsson
  • Is Android affected?: no
Attachment #9442235 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Comment on attachment 9442239 [details]
Bug 1935504 - Update weather widget location search input placeholder string to be translated r?#home-newtab-reviewers

Approved for 133.0.3

Attachment #9442239 - Flags: approval-mozilla-release? → approval-mozilla-release+

I have verified this issue on the latest Firefox dot release 133.0.3 (Build ID: 20241209150345), Firefox Beta 134.0b8 (Build ID: 20241209091406), and the latest Nightly 135.0a1 (Build ID: 20241209213901) on Windows 10 x64, macOS 14.4.1 and Linux Mint 20.1. Here are the results:

On Firefox Beta 134.0b8 and latest Nightly 135.0a1:

  • The issue is no longer reproducible, the string is correctly localized.

On Firefox Dot Release 133.0.3:

  • The issue is still reproducible, the string is NOT localized.

@Maxx, could you please take a look if the patch is successfully merged in Firefox 133.0.3? Or the string is not localized on Firefox 133 because there are some feature differences and the patch is not working as expected compared to Beta and Nightly?

Flags: needinfo?(mcrawford)

@Donal, the patch doesn't seem to work on the Firefox 133.0.3 release. I am pinging you also for visibility.

Flags: needinfo?(dmeehan)

Thanks for the heads up, :maxx will need to investigate.
:maxx this might mean you cannot rollout the experiment on Fx133.
We don't have any more dot releases planned for Fx133.
If your investigation finds anything additional is needed in release, then you will need to wait until Fx134 hits release.

Flags: needinfo?(dmeehan)

@Donal - Got'cha. Understood. Investigating now.

Flags: needinfo?(mcrawford)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: