1935726 - addon post install dialog primary button string should be set to OK to match Acorn style guide

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

Per acorn style guide (see here) the addon post install dialog primary button string should be set to "Ok" instead of "Okay", but also the default of all popup notifications primary button should be set to "Ok" instead of "OK!" and so the patches attached to this issue will be changing the default primary button string to match our acorn style guide and remove the custom primary button string currently used by the addon post install dialog.

As a nice side-effect, any popup notification that isn't setting a custom string for their primary button string will be inheriting a primary button string that already follows the acorn style guide by default.

This bug isn't going to try to track down other primary buttons that may not need a custom string anymore (but at least based on a basic searchfox query the addon post install one may be the only one: e.g. these seems to be all ".buttonlabel = " in our fluent files that can be found in searchfox).

This bugzilla issue has been spun off from Bug 1806301 patch stack, because this part is technically independent from the rest of changes part of that patch stack (and this part less likely to hit some unexpected failure when pushed to autoland).

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1935726 - Use default OK button string in the addon post install dialog. r?robwu!

Depends on D226952

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1935726 - Set default popupnotification button string to OK by default to match Acorn style guide. r?mstriemer!

We have been recently asked to change the "Ok!" and "Okay" buttons across a number of our add-ons related dialogs,
because per Acorn style guide those buttons should use "OK" as the button string and so given that the default
is currently "OK!" it seems we should change it for all dialogs, so that they will all match the Acorn style
guide when using the default popupnotification button string.

See acorn style guide here: https://acorn.firefox.com/latest/content/word-list/n-r-Z1EQFKD6#section-ok-03

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7608d4f8c4c0
Set default popupnotification button string to OK by default to match Acorn style guide. r=mstriemer,fluent-reviewers,reusable-components-reviewers
https://hg.mozilla.org/integration/autoland/rev/adf679cc3160
Use default OK button string in the addon post install dialog. r=robwu

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/7608d4f8c4c0
https://hg.mozilla.org/mozilla-central/rev/adf679cc3160

Comment 5

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly (135.0a1/20241210205259) and Release (133.0.3/20241209150345) for comparison, under Windows 10 and Ubuntu 24.04 LTS.

• the add-on post install dialog button string is set to OK on Nightly 135, as opposed to Okay in Release 133.
• the blocked/restricted add-on denied installation dialog button string is set to OK on Nightly 135, as opposed to OK! in Release 133.
• the corrupted add-on denied installation dialog button string is set to OK on Nightly 135, as opposed to OK! in Release 133.
• the unverified add-on denied installation dialog button string is set to OK on Nightly 135, as opposed to OK! in Release 133.

Considering the above, the issue is fixed. For more details, see the attached screenshot.

Comment 6

[Alex Cornestean]

Attachment: Nightly_OK_string.png