1936093 - Fix test_restoreClosedTabGroupFromClosedWindow

Status: RESOLVED DUPLICATE of bug 1933114

(Firefox :: Session Restore, task, P3)

Description

[Stephen Thompson [:sthompson]]

This test fails on optimized Linux builds (e.g. test-linux1804-64-tsan-qr/opt-mochitest-browser-chrome-swr) but I haven't reproduced it in debug. The failure indicates that the new tabs created by the test fail to all load successfully.

https://treeherder.mozilla.org/jobs?repo=autoland&duplicate_jobs=visible&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=f9e54d382aac3f84b8ba1029a1737d1c720a0881&selectedTaskRun=YhI349ylSbeZYtvc9GQWmw.0&test_paths=browser%2Fcomponents%2Fsessionstore%2Ftest

Failure screenshot shows that perhaps the about:crashes page is not loading correctly, but I'm not sure about the root cause. https://firefoxci.taskcluster-artifacts.net/YhI349ylSbeZYtvc9GQWmw/0/public/test_info/mozilla-test-fail-screenshot_jj2n_ij0.png

Comment 1

[Stephen Thompson [:sthompson]]

After skipping browser_tab_groups_restore_closed_in_closed_window.js, I ran a try run https://treeherder.mozilla.org/jobs?repo=try&revision=4e41bf52c3ab4c837e8290f34366eae17f7fa0ac&selectedTaskRun=Do6oE4OsTBi3-4jrrl8N5A.0 and there were issues with browser_tab_groups_restore_saved.js and browser_tab_groups_restore_closed_in_open_window.js which didn't seem to crop up before. These are not failing each time, but there were some failures every time I reran that suite of tests in that try.

Comment 2

[Stephen Thompson [:sthompson]]

I isolated the problem to ASan tests in all desktop platforms. The tests that I wrote load about:crashes in tabs under test, but ASan builds set MOZ_CRASHREPORTER_DISABLE=1 which has the effect of making about:crashes fail to load in the browser.

I changed all tab group-related tests (my new tests plus existing tests) that use about:crashes and had them load a different URI.

I fixed that as part of 1933114 so I'm marking this as a dupe. I'll increase the points on 1933114 to reflect the time taken by these additional issues.