1936457 - Add a Suggest backend class for Merino

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Drew Willcoxon :adw]

I'd like to add a SuggestBackendMerino class to go along with SuggestBackendRust and SuggestBackendMl. Then we can add a QuickSuggest.backends array and have UrlbarProviderQuickSuggest query all enabled backends. UrlbarProviderQuickSuggest wouldn't need any Merino-specific code anymore.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1936457 - Add a Suggest backend class for Merino.

This adds SuggestBackendMerino and QuickSuggest.backends, an array that
contains all backends. So now we have Rust, ML, and Merino backends.

This also makes some changes to relevancy ranking (added in bug 1923187) because
that was done in _fetchMerinoSuggestions(), which this patch removes.
Previously, ranking was applied to all Merino suggestions at once. With this
patch, it's applied to each suggestion as it's visited by
#filterAndSortSuggestions(), which is now the right place to do it IMO. It
will be easy to expand it to non-Merino suggestions now if we want.

Depends on D231468

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a0de6f342cd
Add a Suggest backend class for Merino. r=daisuke,nanj

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1a0de6f342cd