1932502 - Remove the Suggest JS backend

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Drew Willcoxon :adw]

Should be safe to remove the Suggest JS backend now. Its replacement, the Rust backend, was enabled by default in 124 (bug 1880144).

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1932502 - Remove the Suggest JS backend: Part 1: Update tests.

This patch is part 1 of 4. I tried to break the removal into parts that make
sense individually since removing it all at once would be a much larger patch
that would probably be harder to review.

This part removes add_tasks_with_rust() from both xpcshell and browser tests
and removes some tests that either aren't enabled without Rust or don't make
sense without it.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1932502 - Remove the Suggest JS backend: Part 2: Remove the backend.

This is part 2 of 4, the main part. It removes the backend and the code in
BaseFeature and feature subclasses that hook into it. As a consequence it also
makes the other following changes:

• Remove QuickSuggest.backend (eventually I'd like to add a Merino backend and
  then add a new QuickSuggest.backends list that has the Rust, Merino, and ML
  backends)
• Add QuickSuggest.config
• Replace uses of QuickSuggest.backend.config and QuickSuggest.jsBackend.config
  with QuickSuggest.config
• Remove the quickSuggestRustEnabled Nimbus variable
• Update most remaining tests so that they do not assume the JS backend exists

I left the browser.urlbar.quicksuggest.rustEnabled pref. I would like to
preserve the ability to toggle off Rust suggestions while keeping other parts of
Suggest enabled even if we don't need it now. That seems like a wise thing to do
and is similar to how both Merino and the ML backends can be toggled separately.

Depends on D231465

Comment 3

[Drew Willcoxon :adw]

Attachment: Bug 1932502 - Remove the Suggest JS backend: Part 3: Remove the "remote-settings" and "rs_" source.

This is part 3 of 4. It removes the "remote-settings" source used internally
and its rs_ counterpart in telemetry result types.

Depends on D231466

Comment 4

[Drew Willcoxon :adw]

Attachment: Bug 1932502 - Remove the Suggest JS backend: Part 4: Remove other Nimbus variables and legacy telemetry.

This is part 4 of 4. There are some Nimbus variables that are now unused plus
one legacy histogram.

Depends on D231467

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1939ed50f17
Remove the Suggest JS backend: Part 1: Update tests. r=daisuke
https://hg.mozilla.org/integration/autoland/rev/455237b42be5
Remove the Suggest JS backend: Part 2: Remove the backend. r=daisuke
https://hg.mozilla.org/integration/autoland/rev/53e4d280499d
Remove the Suggest JS backend: Part 3: Remove the "remote-settings" and "rs_" source. r=daisuke
https://hg.mozilla.org/integration/autoland/rev/4c203310fe82
Remove the Suggest JS backend: Part 4: Remove other Nimbus variables and legacy telemetry. r=daisuke

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/f1939ed50f17
https://hg.mozilla.org/mozilla-central/rev/455237b42be5
https://hg.mozilla.org/mozilla-central/rev/53e4d280499d
https://hg.mozilla.org/mozilla-central/rev/4c203310fe82