1936876 - Remove moz-toggle related exceptions from the browser_parsable_css test

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Hanna Jones [:hjones]]

As part of the work for bug 1917305 I had to add some temporary exceptions to the browser_parsable_css test for moz-toggle CSS variables. These unused variables are actually coming from our vendored version of pdf.js, so they need to be removed in the upstream version of that project then incorporated into mozilla-central when a new version of the package is released. Once that's done we should remove the exceptions that were added.

Comment 1

[Rob Wu [:robwu]]

Calixte, you added a fork of the moz-toggle button in bug 1867740. The styles changed in https://hg.mozilla.org/mozilla-central/rev/168f6caa3b16 .
Could you look into matching the updated styles? Interestingly, you recognized that the style may change when you added TODO: check from times to times if the original file has been updated.

The following two variables are currently unused:
https://github.com/mozilla/pdf.js/blob/8985d80aef7678cbf0c5fe119578560f14f4b6ce/web/toggle_button.css#L202-L205

Firefox has a unit test that detects unused variables, and to unblock bug 1917305 a temporary exception was added at https://searchfox.org/mozilla-central/rev/5a7e5e2e1fe04028fc77787084caf9b26ab74ce6/browser/base/content/test/static/browser_parsable_css.js#168-171

Based on the name, it looks like the intent for the style is to visually disable the toggle when the item is disabled. When I set the button's disabled property to true, the toggle is not visually rendered as disabled. Even if PDF.js does currently not disable the toggle, it would be a nice-to-have if the stylesheet included :disabled style to visually disable the button when the button is toggled.

Comment 2

[Calixte Denizet (:calixte)]

Attachment: Bug 1936876 - Remove moz-toggle in pdf.js related exceptions from the browser_parsable_css test r=hjones

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56dc9430aff6
Remove moz-toggle in pdf.js related exceptions from the browser_parsable_css test r=hjones

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/56dc9430aff6