1917305 - Use form helpers for moz-toggle

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P2)

Description

[Mark Striemer [:mstriemer]]

We should use our form helpers from bug 1900122 for the moz-toggle component. This will entail moving the toggle before the label so will be a little more work and verification vs the moz-radio and moz-checkbox

Comment 1

[Hanna Jones [:hjones]]

Attachment: Bug 1917305 - Part 1: Fix spacing in moz-checkbox and base input elements r=#recomp-reviewers

Comment 2

[Hanna Jones [:hjones]]

Attachment: Bug 1917305 - Part 2: Update moz-toggle to use the base input class r=#recomp-reviewers

Comment 3

[Hanna Jones [:hjones]]

Attachment: Bug 1917305 - Part 3: Update moz-toggle tests to use the input test helpers r=#recomp-reviewers

Comment 4

[Hanna Jones [:hjones]]

Attachment: Bug 1917305 - Part 4: Update search and suggest toggles in settings r=#search-reviewers,#settings-reviewers

Comment 5

[Hanna Jones [:hjones]]

Attachment: Bug 1917305 - Part 5: Update shopping toggles r=#shopping-reviewers

Comment 6

[Hanna Jones [:hjones]]

Attachment: Bug 1917305 Part 6: implement nested fields to address newtab settings drawer spacing r=#home-newtab-reviewers,#recomp-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab9d3dcb9ac7
Part 1: Fix spacing in moz-checkbox and base input elements r=reusable-components-reviewers,mstriemer
https://hg.mozilla.org/integration/autoland/rev/488458777db0
Part 2: Update moz-toggle to use the base input class r=reusable-components-reviewers,mstriemer
https://hg.mozilla.org/integration/autoland/rev/5b6f08a5fd6c
Part 3: Update moz-toggle tests to use the input test helpers r=reusable-components-reviewers,mstriemer
https://hg.mozilla.org/integration/autoland/rev/a1fe92460a5d
Part 4: Update search and suggest toggles in settings r=urlbar-reviewers,Standard8
https://hg.mozilla.org/integration/autoland/rev/ea78740bd5b1
Part 5: Update shopping toggles r=shopping-reviewers,kpatenio
https://hg.mozilla.org/integration/autoland/rev/54eeb575b705
Part 6: implement nested fields to address newtab settings drawer spacing r=home-newtab-reviewers,reusable-components-reviewers,mconley,mstriemer

Comment 8

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_parsable_css.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/07b4f2ca644ff9b093bfeaf5d771d99c339c0e63

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f538e9697cb3
Part 1: Fix spacing in moz-checkbox and base input elements r=reusable-components-reviewers,mstriemer
https://hg.mozilla.org/integration/autoland/rev/d0749e2b61fc
Part 2: Update moz-toggle to use the base input class r=reusable-components-reviewers,mstriemer
https://hg.mozilla.org/integration/autoland/rev/0b20c8187edc
Part 3: Update moz-toggle tests to use the input test helpers r=reusable-components-reviewers,mstriemer
https://hg.mozilla.org/integration/autoland/rev/8c3b26eb05e7
Part 4: Update search and suggest toggles in settings r=urlbar-reviewers,Standard8
https://hg.mozilla.org/integration/autoland/rev/f148cb47b84f
Part 5: Update shopping toggles r=shopping-reviewers,kpatenio
https://hg.mozilla.org/integration/autoland/rev/a11742cbdf6c
Part 6: implement nested fields to address newtab settings drawer spacing r=home-newtab-reviewers,reusable-components-reviewers,mconley,mstriemer

Comment 10

[Atila Butkovits]

Backed out for causing failure at browser_parsable_css.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/33153975be85628977ca3ef23958d8ef0590b273

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=M0uLLbViTSmOWIAmBjE6xw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a11742cbdf6c6f00883d361d8c6393d64933662a

Failure log: https://treeherder.mozilla.org/logviewer?job_id=486483722&repo=autoland&lineNumber=2534

Comment 11

[Hanna Jones [:hjones]]

Attachment: Bug 1917305 Part 7: add temporary exception for unused toggle vars in pdf.js r=#recomp-reviewers

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d176a670f6d
Part 1: Fix spacing in moz-checkbox and base input elements r=reusable-components-reviewers,mstriemer
https://hg.mozilla.org/integration/autoland/rev/168f6caa3b16
Part 2: Update moz-toggle to use the base input class r=reusable-components-reviewers,mstriemer
https://hg.mozilla.org/integration/autoland/rev/da06d8bfc8db
Part 3: Update moz-toggle tests to use the input test helpers r=reusable-components-reviewers,mstriemer
https://hg.mozilla.org/integration/autoland/rev/a520c61b3bd3
Part 4: Update search and suggest toggles in settings r=urlbar-reviewers,Standard8
https://hg.mozilla.org/integration/autoland/rev/bbdcbe700c38
Part 5: Update shopping toggles r=shopping-reviewers,kpatenio
https://hg.mozilla.org/integration/autoland/rev/af48443872d6
Part 6: implement nested fields to address newtab settings drawer spacing r=home-newtab-reviewers,reusable-components-reviewers,mconley,mstriemer
https://hg.mozilla.org/integration/autoland/rev/840b6bd0d6e4
Part 7: add temporary exception for unused toggle vars in pdf.js r=reusable-components-reviewers,mstriemer

Comment 13

[amarc]

https://hg.mozilla.org/mozilla-central/rev/1d176a670f6d
https://hg.mozilla.org/mozilla-central/rev/168f6caa3b16
https://hg.mozilla.org/mozilla-central/rev/da06d8bfc8db
https://hg.mozilla.org/mozilla-central/rev/a520c61b3bd3
https://hg.mozilla.org/mozilla-central/rev/bbdcbe700c38
https://hg.mozilla.org/mozilla-central/rev/af48443872d6
https://hg.mozilla.org/mozilla-central/rev/840b6bd0d6e4