1937059 - 2.48% bing-search SpeedIndex (Linux) regression on Thu December 5 2024

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, defect, P2)

Description

[Treeherder Bug Filer]

Perfherder has detected a browsertime performance regression from push 5c927e89451bcf64289953bc6e478bfe3197cb3a. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
2%	bing-search SpeedIndex	linux1804-64-shippable-qr	bytecode-cached cold fission webrender	630.44 -> 646.06	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 43009

The following documentation link provides more information about this command.

For more information on performance sheriffing please see our FAQ.

If you have any questions, please do not hesitate to reach out to [e-mail].

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1928132

Comment 2

[Marco Bonardo [:mak]]

We should go through the before/after profiles and see if anything can explain the regression.
Off-hand we didn't notice very obvious reasons for it, in the after screenshots the button is always hidden, while it's always visible before.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

It has been over 7 days with no activity on this performance regression.

:daisuke, since you are the author of the regressor, bug 1928132, which triggered this performance alert, could you please provide a progress update?

If this regression is something that fixes a bug, changes the baseline of the regression metrics, or otherwise will not be fixed, please consider closing it as WONTFIX. See this documentation for more information on how to handle regressions.

For additional information/help, please needinfo the performance sheriff who filed this alert (they can be found in comment #0), or reach out in #perftest, or #perfsheriffs on Element.

For more information, please visit BugBot documentation.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

It has been over 7 days with no activity on this performance regression.

:daisuke, since you are the author of the regressor, bug 1928132, which triggered this performance alert, could you please provide a progress update?

If this regression is something that fixes a bug, changes the baseline of the regression metrics, or otherwise will not be fixed, please consider closing it as WONTFIX. See this documentation for more information on how to handle regressions.

For additional information/help, please needinfo the performance sheriff who filed this alert (they can be found in comment #0), or reach out in #perftest, or #perfsheriffs on Element.

For more information, please visit BugBot documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

It has been over 7 days with no activity on this performance regression.

:daisuke, since you are the author of the regressor, bug 1928132, which triggered this performance alert, could you please provide a progress update?

If this regression is something that fixes a bug, changes the baseline of the regression metrics, or otherwise will not be fixed, please consider closing it as WONTFIX. See this documentation for more information on how to handle regressions.

For additional information/help, please needinfo the performance sheriff who filed this alert (they can be found in comment #0), or reach out in #perftest, or #perfsheriffs on Element.

For more information, please visit BugBot documentation.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

It has been over 7 days with no activity on this performance regression.

:daisuke, since you are the author of the regressor, bug 1928132, which triggered this performance alert, could you please provide a progress update?

If this regression is something that fixes a bug, changes the baseline of the regression metrics, or otherwise will not be fixed, please consider closing it as WONTFIX. See this documentation for more information on how to handle regressions.

For additional information/help, please needinfo the performance sheriff who filed this alert (they can be found in comment #0), or reach out in #perftest, or #perfsheriffs on Element.

For more information, please visit BugBot documentation.

Comment 7

[Marco Bonardo [:mak]]

The only related difference I see betwen the profiles is a call to updateUrlbarToggle related to pip that appears in the second profile, but it's not the first. I also see some additional IPC messages. This makes me think to a timing shift, other things entered in the measurement timeframe.

There is some optimization work that could be saved around the unified search button, like avoiding to set stuff if nothing changed, as well as we could delay certain things to when it becomes visible. But the work done is the same here before and after the change.
Apart from that, mostly unrelated to the regression though, this doesn't look like actionable to me.