Closed Bug 1928132 Opened 3 months ago Closed 2 months ago

Dont show dedicated search button permanently

Categories

(Firefox :: Address Bar, enhancement, P2)

Product:
Firefox
Component:
Address Bar
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
135 Branch
Tracking Flags:
Tracking Status
firefox135 --- fixed

People

(Reporter: daleharvey, Assigned: daisuke)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [sng-scotchbonnet])

User Story

As a user, when I land on Homepage New Tab, I want to see the AddressBar with the Unified Search Button (USB).

As a user, when I navigate to a website, I want the USB to be hidden while I browse that website.

As a user, when I tab into the address bar (on any component) I want the USB to unhide.

As a user, when I open the AddressBar dropdown and the USB remains hidden

As a user, when I start editing the url, I want the P&S Icons to disappear and the USB to appear.

As a user, when I am on a loaded website, when I move focus away from the AddressBar, I want the USB to disappear.

Attachments

(3 files, 1 obsolete file)

Bug 1928132: Show Unified Search Button always
48 bytes, text/x-phabricator-request
Details | Review
Bug 1928132: Implement dynamic Unified Search Button mode
48 bytes, text/x-phabricator-request
Details | Review
example of USB not matching keyworded search
42.04 KB, image/png
Details

The dedicated search button is currently shown all the time which causes various issues, an updated spec has been made to show and hide the buttons in the correct context

Blocks: 1891862
Whiteboard: [sng-scotchbonnet]
User Story: (updated)
Duplicate of this bug: 1928154
Assignee: nobody → daisuke
See Also: → 1930470
Duplicate of this bug: 1928311
Duplicate of this bug: 1930470
See Also: 1930470 →

Hey, so after lengthy discussions on Slack and some meetings I wanted to jot down what the current agreed plan is:

  1. We will move the button to the left
  2. There will be a baseline / fallback behaviour. The USB icon will shown at all times and will be a magnifying glass at all times (only replaced by search mode chicklet)
  3. Behind a pref, with the pref enabled by default, The USB icon will show the default engine icon, it will be shown by default on the newtab page and when the user focuses the urlbar and it will hide when the urlbar is not focused.

Josh has protytpes of both behaviours, pref off, permanent usb with magnifying glass icon:
https://www.figma.com/proto/4co0kOw3eJMQK3HRpTuD1b/Unified-search-button?page-id=2890%3A53781&node-id=3066-68835&node-type=frame&viewport=1186%2C1509%2C0.24&t=CCSfrqeLvUZENLfy-1&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=3066%3A68835&show-proto-sidebar=1

pref on, usb show/hide on focus with default search icon icon:
https://www.figma.com/proto/4co0kOw3eJMQK3HRpTuD1b/Unified-search-button?page-id=2890%3A53781&node-id=2890-63462&node-type=frame&viewport=1186%2C1509%2C0.24&t=CCSfrqeLvUZENLfy-1&scaling=min-zoom&content-scaling=fixed&starting-point-node-id=2890%3A63462&show-proto-sidebar=1

Attachment #9436031 - Attachment is obsolete: true

Hello,

As a user, one other context where the USB is confusing: when typing in the address bar starting with a search keyword. I have a lot of search fields bookmarked with a search keyword. So for instance I’ll start typing wp to search Wikipedia, but then the USB still shows the icon of the default search engine, which is confusing, and I have to pause for a moment to understand that it’s not that Firefox didn’t recognise my search keyword, it’s just that this button is unrelated.

So I’d say either hide the USB when a bookmarked search keyword is recognised, or likely better, use the opportunity to display the bookmarked favicon (and name?) in the USB, integrating the two features together?

Thans!

Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0d13b91f55e0 Show Unified Search Button always r=desktop-theme-reviewers,daleharvey,dao https://hg.mozilla.org/integration/autoland/rev/5882194e7456 Implement dynamic Unified Search Button mode r=desktop-theme-reviewers,daleharvey,dao,tabbrowser-reviewers

Backed out for causing bc failures browser_popupNotification_2.js

Flags: needinfo?(daisuke)
Regressions: 1934251
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4a72ad308d0c Show Unified Search Button always r=desktop-theme-reviewers,daleharvey,dao https://hg.mozilla.org/integration/autoland/rev/2ea4986f9eb8 Implement dynamic Unified Search Button mode r=desktop-theme-reviewers,daleharvey,dao,tabbrowser-reviewers

https://hg.mozilla.org/mozilla-central/rev/4a72ad308d0c
https://hg.mozilla.org/mozilla-central/rev/2ea4986f9eb8

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox135: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
Regressions: 1934387
Regressions: 1934388
Regressions: 1934389

Backed out for causing failures on browser_mouseout_notification_panel.js and Bug 1934387, Bug 1934388, Bug 1934389

Backout link

Push with failures

Failure log

Status: RESOLVED → REOPENED
status-firefox135: fixed → ---
Resolution: FIXED → ---
Target Milestone: 135 Branch → ---
Regressed by: 1934408
Type: enhancement → defect
Keywords: regression
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ea680965029a Show Unified Search Button always r=desktop-theme-reviewers,daleharvey,dao https://hg.mozilla.org/integration/autoland/rev/5c927e89451b Implement dynamic Unified Search Button mode r=desktop-theme-reviewers,daleharvey,dao,tabbrowser-reviewers
User Story: (updated)

https://hg.mozilla.org/mozilla-central/rev/ea680965029a
https://hg.mozilla.org/mozilla-central/rev/5c927e89451b

Status: REOPENED → RESOLVED
Closed: 2 months ago → 2 months ago
status-firefox135: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch

Shifting the address text to the right, when the search button appears, is very annoying and distracing (please see also the regression bug 1934408). Maybe the first focus into the address bar (via mouse click or CMD-L or CTRL-L) should not make the search button appear so that nothing shifts. Then a second click could show the button and make the text shifting to the right. Chrome has a similar solution with showing the whole address incl. the https:// string. Only the second click make the https:// string appear. With that they avoid the movement of the text with the first focus.

Or keep the search button as an fixed button on the address bar or add an option to hide the search button at all from the address bar or implement it as an extra button on the toolbar or add a right-click option to the address bar to change the search provider, or, or, or ... There are so many possibilities without any annoying and distracting things. But please don't stress the (remaining loyal Firefox-)users eyes with these annoying and distracting address bar element movements !!!

Many thanks for listening!

Type: defect → enhancement
Keywords: regression
No longer regressed by: 1934408
Regressions: 1934408
Flags: needinfo?(daisuke)

Thank you very much for your feedback, Mehmet !
Yes, we also think this is an issue. We have an idea, will fix in bug 1936090
Until fixing it, if change browser.urlbar.usb.dynamic to false, it shows Unified Search Button always, please try it if you want.

(In reply to Daisuke Akatsuka (:daisuke) from comment #19)

Thank you very much for your feedback, Mehmet !
Yes, we also think this is an issue. We have an idea, will fix in bug 1936090
Until fixing it, if change browser.urlbar.usb.dynamic to false, it shows Unified Search Button always, please try it if you want.

Thanks for your reply and consideration !

Regressions: 1937059
Regressions: 1938443
Blocks: 1936291
No longer depends on: 1936291
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: