Closed Bug 1937074 Opened 2 months ago Closed 2 months ago

Unified Search Button shows icon of normal default engine instead of private default engine in private browsing mode

Categories

(Firefox :: Address Bar, defect, P1)

Product:
Firefox
Component:
Address Bar
Version:
Firefox 135
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
135 Branch
Tracking Flags:
Tracking Status
firefox135 --- verified

People

(Reporter: mbeier, Assigned: mbeier)

References

Details

(Whiteboard: [sng])

Attachments

(1 file)

Bug 1937074 - Fix unified search button showing icon of normal default engine instead of private default engine in private browsing mode. r?#urlbar-reviewers
48 bytes, text/x-phabricator-request
Details | Review

STR

1: Set the following pref to true:
browser.search.separatePrivateDefault.ui.enabled

2: Set a default private search engine in about:settings#search

3: Open a private window and click the addressbar

Expected: USB shows icon of the default private engine
Actual: USB shows icon of normal default engine

Assignee: nobody → mbeier
Status: NEW → ASSIGNED
Severity: -- → S2
Priority: -- → P1
Summary: USB shows icon of normal default engine instead of private default engine in private browsing mode → Uniofied Search Button shows icon of normal default engine instead of private default engine in private browsing mode
Summary: Uniofied Search Button shows icon of normal default engine instead of private default engine in private browsing mode → Unified Search Button shows icon of normal default engine instead of private default engine in private browsing mode
Attachment #9443437 - Attachment description: Bug 1937074 - Fix USB showing icon of normal default engine instead of private default engine in private browsing mode. r?#urlbar-reviewers → Bug 1937074 - Fix unified search button showing icon of normal default engine instead of private default engine in private browsing mode. r?#urlbar-reviewers
Pushed by mbeier@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e8da1039fe2f Fix unified search button showing icon of normal default engine instead of private default engine in private browsing mode. r=urlbar-reviewers,daisuke

https://hg.mozilla.org/mozilla-central/rev/e8da1039fe2f

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox135: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
Regressions: 1938244
No longer regressions: 1938244

Verified as fixed on latest Nightly 135.0a1 2024-12-19 across system, with a small follow-up logged as bug 1938567.

Status: RESOLVED → VERIFIED
status-firefox135: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: