1938567 - Unified Search Button icon is not refreshed on private window when changing default search engine for private mode

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Petruta Horea [:phorea], Desktop Test Engineering]

Attachment: USB icon still showing previous engine

Notes

• This is a small follow-up of bug 1937074

Found in
Nightly 135.0a1 2024-12-19;

Affected versions
Nightly 135.0a1;

Affected platforms
Windows 10/11;
Ubuntu 22;
macOS 14;

Steps to reproduce

1. Set the following pref to true:
   browser.search.separatePrivateDefault.ui.enabled
2. Open a private window and place it next to the normal window (both normal and private windows are in view)
3. Set a default private search engine in about:settings#search
4. Observe the engine changing in the private window

Expected result
New engine is displayed everywhere on the private window (USB, urlbar label and websearch)

Actual result
USB icon shows the icon of the normal window default engine - until switching tabs. Refresh won't solve the issue.
Searches from urlbar/websearch are correctly done with the private set engine.

Regression range
bug 1937074

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:mbeier, since you are the author of the regressor, bug 1937074, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Moritz Beier [:mbeier]]

Attachment: Bug 1938567 - Update Unified Search Button icon after default private engine changes. r?#urlbar-reviewers

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:daisuke, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ffec3016dee
Update Unified Search Button icon after default private engine changes. r=urlbar-reviewers,daisuke

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_suppressFocusBorder.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/8ca64c6158f06dcb67cddd15eabe70060ed57e1c

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_suppressFocusBorder.js | A promise chain failed to handle a rejection: can't access property "QueryInterface", aWindow.docShell is null

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7eb0a1b0086f
Update Unified Search Button icon after default private engine changes. r=urlbar-reviewers,daisuke

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7eb0a1b0086f

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mbeier, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox135 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-12-20 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 136.0a1 on Windows 10, Ubuntu 22, macOS 14.