Closed Bug 1937170 Opened 1 month ago Closed 14 hours ago

Transfer ownership of ActivityStreamStorage to ASRouter

Categories

(Firefox :: New Tab Page, task, P1)

Product:
Firefox
Component:
New Tab Page
Type:
task
Points:
3

Tracking

()

Status:
RESOLVED FIXED
Milestone:
136 Branch
Iteration:
136.1 - Jan 6 - Jan 17
Tracking Flags:
Tracking Status
firefox136 --- fixed

People

(Reporter: mconley, Assigned: pdahiya)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [hnt-trainhop])

Attachments

(1 file)

Bug 1937170 - Transfer ownership of ActivityStreamStorage to ASRouter
48 bytes, text/x-phabricator-request
Details | Review

The only thing still using ActivityStreamStorage in the New Tab codebase is the SectionsManager (which is from a 2017-era project, and is not related to the ongoing project with a similar name).

Everything else using ActivityStreamStorage is ASRouter-y, so we should transfer ownership.

Depends on: 1937172
Whiteboard: [hnt-trainhop]
Assignee: nobody → pdahiya
Iteration: --- → 136.1 - Jan 6 - Jan 17
Points: --- → 3
Priority: -- → P1
Blocks: 1937172
No longer depends on: 1937172

Tried moving ActivityStreamStorage to ASRouter in attached patch first before removing section manager usage of ActivityStreamStorage as it helps understand which part of SectionManager and rest of newtab code is using this API and why. Thanks

Pushed by pdahiya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/86456e2a4960 Transfer ownership of ActivityStreamStorage to ASRouter r=backup-reviewers,home-newtab-reviewers,omc-reviewers,mconley,aminomancer

https://hg.mozilla.org/mozilla-central/rev/86456e2a4960

Status: NEW → RESOLVED
Closed: 14 hours ago
status-firefox136: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: