1937172 - Remove the ability to move sections from the 2017-era SectionsManager, and remove dependency on ASRouterStorage

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

The SectionsManager is from a bygone era, and isn't actively used in the way it was designed for. We should remove it if we can, or shrink it considerably if it's inextricably tied to the functioning of today's New Tab.

One of the things that SectionsManager does make use of is ActivityStreamStorage, so this blocks bug 1937170.

Comment 1

[npypchenko]

Attachment: WIP: Bug 1937172 - Remove the 2017-era SectionsManager from New Tab

• Removed unused moveSection function and associated tests.

• Removed unused actions originating in SectionsManager and assiciated tests.

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1937172 - Remove SectionManager and TopSitesFeed dependancy on ASRouterStorage

Comment 3

[Punam Dahiya [:pdahiya]]

Attaching patch that removes NewTab codebase (SectionManager, TopSitesFeed, PrefsFeed) dependency on ASRouterStorage by removing unused sectionprefs indexedDb table. In addition it removes unused SECTION_MOVE action handling from SectionManager

Comment 4

[Mike Conley (:mconley) (:⚙️)]

It seems that SectionManager is still pretty intertwined with New Tab. We can, however, remove it's dependency on ASRouterStorage.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fba96c11ef5
Remove SectionManager and TopSitesFeed dependancy on ASRouterStorage r=home-newtab-reviewers,omc-reviewers,mconley,emcminn

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/6fba96c11ef5

Comment 7

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fba96c11ef5
Remove SectionManager and TopSitesFeed dependancy on ASRouterStorage
r=home-newtab-reviewers,omc-reviewers,mconley,emcminn

Perfherder has detected a talos performance change from push 6fba96c11ef5f66ce2b38de72acbd8cae528c2af.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
2%	startup_about_home_paint	windows11-64-shippable-qr	e10s fission stylo webrender-sw	430.17 -> 421.33

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 43477

For more information on performance sheriffing please see our FAQ.