1937700 - Fix secure IRC protcol handler in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, defect)

Description

[Ian Neal]

As part of bug 1926406 the IRC protocol handlers were merged into chatzilla-service.js, unfortunately there was a typo in a call to a function which meant the insecure rather than the secure protocol handler was used.

Comment 1

[Ian Neal]

Attachment: 1937700-irc-protocol-25320.patch

[Approval Request Comment]
Regression caused by (bug #): 1926406
User impact if declined: irc rather than ircs used when clicking on ircs links
Testing completed (on m-c, etc.): 2.53.20pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Just calls GenericIRCProtocolHandler with true or false directly rather than having separate handlers for ircs and irc which then call the generic handler.

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9443992 [details] [diff] [review]
1937700-irc-protocol-25320.patch

lgtm r/a+

[Triage Comment]

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fe2f68ab9284
Fix secure IRC protcol handler in cZ. r=frg

Comment 4

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/5f78ee130b9e844a263b012634fd929680a12741
Fix secure IRC protcol handler in cZ. r=frg a=frg