1938036 - Keyword is retained for Contextual Search mode(click) when access point is not a search form and engine is autofilled

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Adrian Florinescu [:aflorinescu]]

Found in

• Nightly 135.0a1;

Affected versions

• Nightly 135.0a1;

Tested platforms

• Affected platforms: Windows 11, Mac 13, Ubuntu 24

Preconditions

• The default list search engine, excluding the default search engine already has autofill for the start strig: e.g: bin will autofill to bing.com

Steps to reproduce

1. Open new tab page.
2. Input a string in the address bar that would match an engine from the default list, excluding the default engine list: e.g: duc , bin - the string entered autofills to duckduck.go, bing.com
3. Use mouse to click on the offered contextual search (old tab to search)
   3'. Use tab to navigate to the offered contextual search (old tab to search)

Expected result
3. Search mode is entered without search term
3'. Search mode is entered without search term.

Actual result
3. Search mode is entered without the search term when pressing tab.
3'. Search mode is entered with search term when using mouse click.

Regression range

• N/A

Note

• If there is no autofill for used search engine or autofill is removed before contextual search secondary action is clicked, the bug doesn't reproduce.
• In this case, when accessing contextual search from a non-search form page and basically using the old tab to search functionality, the search word should be scrapped since thats not the intent.

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1938036 - Dont maintain user input when selecting contextual engine. r=daisuke

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the following bug duplicate has higher severity:

• Bug 1937021: S2

:daleharvey, could you consider increasing the severity of this bug to S2?

For more information, please visit BugBot documentation.

Comment 5

[Dale Harvey (:daleharvey)]

edit old comment accidently posted

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7114c02d6a5
Dont maintain user input when selecting contextual engine. r=daisuke,urlbar-reviewers

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c7114c02d6a5

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daleharvey, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox135 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2024-12-17 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 136.0a1 on Windows 10, Ubuntu 22, macOS 14.