1938160 - Remove or replace the Region health telemetry probes

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

We have a few region probes that are not providing significantly useful data. We should review these and the code around them and determine the best way forward:

• SEARCH_SERVICE_US_COUNTRY_MISMATCHED_TIMEZONE
• SEARCH_SERVICE_US_TIMEZONE_MISMATCHED_COUNTRY
• SEARCH_SERVICE_NONUS_COUNTRY_MISMATCHED_PLATFORM_OSX
• SEARCH_SERVICE_NONUS_COUNTRY_MISMATCHED_PLATFORM_WIN
• SEARCH_SERVICE_US_COUNTRY_MISMATCHED_PLATFORM_OSX
• SEARCH_SERVICE_US_COUNTRY_MISMATCHED_PLATFORM_WIN

The SEARCH_SERVICE_US_COUNTRY_MISMATCHED_TIMEZONE and SEARCH_SERVICE_US_TIMEZONE_MISMATCHED_COUNTRY are also kind: flag histograms which we are looking to remove (bug 1935160).

Comment 1

[Mark Banner (:standard8)]

After reviewing the probes and existing data, we have decided to remove the existing probes and replace them for a single probe.

The existing probes are not completely accurate as, for example, they count a person with a region of CA as being in the wrong region if the timezone is thought to be a US timezone. We also don't have a reference for how many times a success is seen, so we don't have the rate of failures.

Additionally, the existing probes are not particularly useful at the moment as we're not working on changing the region code, and we can monitor in other ways.

For the new probe, we do want to monitor when we "throw away" the region due to the timezone not being in the US. I think we should use a labelled counter with labels of:

• region_set_row (rest of world)
• region_set_us
• region_set_incorrect_timezone_us

This should then give us a rate for how often skip the region setting.

I'm working on patches for this.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1938160 - Remove the existing Region health telemetry probes. r?#search-reviewers!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1938160 - Add a probe to record if the region is skipped due to no matching the timezone. r?#search-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d4c074bcacc
Remove the existing Region health telemetry probes. r=search-reviewers,scunnane
https://hg.mozilla.org/integration/autoland/rev/59daaa2b96ef
Add a probe to record if the region is skipped due to no matching the timezone. r=search-reviewers,scunnane

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2d4c074bcacc
https://hg.mozilla.org/mozilla-central/rev/59daaa2b96ef