Closed Bug 1938206 Opened 1 year ago Closed 1 year ago

Hide shopping-header when sidebar.revamp is false

Categories

(Firefox Graveyard :: Shopping, defect, P2)

Tracking

(firefox136 verified, firefox137 verified)

VERIFIED FIXED
136 Branch
Tracking Status
firefox136 --- verified
firefox137 --- verified

People

(Reporter: fchasen, Assigned: rking)

References

Details

(Whiteboard: [fidefe-RCSidebar])

Attachments

(1 file, 1 external file)

Attached image revampoff.png —

If sidebar.revamp=false and the Review Checker sidebar is enabled, we display both the header for switching the sidebars and the shopping-header.

We should hide the <head id="shopping-header"> in shopping-container when the sidebar.revamp pref is false. We can get this with RPMGetBoolPref if we allow it in RemotePageAccessManager.sys.mjs.

The sidebar will be closed (and RC sidebar removed) when the pref is changed to no need to listen for updates.

I think we will also need to add something like (Beta) to the menu-view-review-checker label in sidebar.ftl

Assignee: nobody → rking
Attachment #9444667 - Attachment description: WIP: Bug 1938206 - Hide shopping-header when sidebar.revamp is false to prevent double Review Checker header - WIP → Bug 1938206 - Hide shopping-header when sidebar.revamp is false to prevent double Review Checker header - r=#shopping-reviewers

The severity field is not set for this bug.
:jhirsch, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jhirsch)
Pushed by rking@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/546b0dd1ef45 Hide shopping-header when sidebar.revamp is false to prevent double Review Checker header - r=shopping-reviewers,fchasen
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch

Verified as fixed in our latest Nightly build as well as our latest Beta 136.0b1

Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
Flags: needinfo?(jhirsch)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: